V5: [MessageList] Update bubbles and text colors in messages#1142
Draft
V5: [MessageList] Update bubbles and text colors in messages#1142
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
laevandus
commented
Jan 27, 2026
Comment on lines
-145
to
-149
| let path = UIBezierPath( | ||
| roundedRect: rect, | ||
| byRoundingCorners: corners, | ||
| cornerRadii: CGSize(width: cornerRadius, height: cornerRadius) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Bubble corners started to be drawn using the Apple's continuous style instead of circular which does not give what we want (only when message is super small). Creating the path with circular arcs fixes it. Much longer, but works.
Co-authored-by: Stream Bot <ci@getstream.io>
laevandus
changed the title
Generated by 🚫 Danger |
laevandus
commented
Jan 27, 2026
| } else { | ||
| Text(message.adjustedText) | ||
| .font(fonts.emoji) | ||
| .padding(.horizontal, tokens.spacingSm) |
Contributor
Author
There was a problem hiding this comment.
Yes, emojis have bubbles now
Contributor
There was a problem hiding this comment.
let's challenge that, it's not really standard. Raised it in figma, but let's keep it for now.
Co-authored-by: Stream Bot <ci@getstream.io>
Contributor
martinmitrevski
left a comment
martinmitrevski
left a comment
There was a problem hiding this comment.
- bottom style reactions don't seem to match any more (they're less rounded)
- there are some missing borders/bubbles, e.g. MessageView_Tests/test_messageViewImage_snapshot.1.png
| } else { | ||
| Text(message.adjustedText) | ||
| .font(fonts.emoji) | ||
| .padding(.horizontal, tokens.spacingSm) |
Contributor
There was a problem hiding this comment.
let's challenge that, it's not really standard. Raised it in figma, but let's keep it for now.
Co-authored-by: Stream Bot <ci@getstream.io>
# Conflicts: # StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/ChatChannelViewDateOverlay_Tests/test_chatChannelView_snapshot.1.png # StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/ChatChannelView_Tests/test_chatChannelView_snapshot.1.png # StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/ChatChannelView_Tests/test_chatChannelView_themedNavigationBar_snapshot.1.png # StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/MessageComposerView_Tests/test_composerQuotedMessage_translated.default-dark.png # StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/MessageComposerView_Tests/test_composerQuotedMessage_translated.default-light.png # StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/MessageComposerView_Tests/test_composerView_draftWithVoiceRecordingAttachment.default-light.png # StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/MessageComposerView_Tests/test_composerView_editingMessageWithVoiceRecording.default-light.png # StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/MessageComposerView_Tests/test_messageComposerView_addedVoiceRecording.1.png # StreamChatSwiftUITests/Tests/ChatChannel/__Snapshots__/MessageListViewLastGroupHeader_Tests/test_messageListView_headerOnTop.1.png
…tStream/stream-chat-swiftui into v5-message-list-text-messages
Co-authored-by: Stream Bot <ci@getstream.io>
|
# Conflicts: # StreamChatSwiftUI.xcodeproj/project.pbxproj
laevandus
commented
Jan 28, 2026
| } | ||
| ) | ||
| ) : nil, | ||
| alignment: messageViewModel.isRightAligned ? .trailing : .leading |
Contributor
Author
There was a problem hiding this comment.
It was easier to handle it like this when bubble is really small
Co-authored-by: Stream Bot <ci@getstream.io>
Public Interface+ public enum ReactionsStyle
+
+ case clustered
+ case segmented
public struct MessageModifierInfo
- public var cornerRadius: CGFloat
+ public var cornerRadius: CGFloat?
- public init(message: ChatMessage,isFirst: Bool,injectedBackgroundColor: UIColor? = nil,cornerRadius: CGFloat = 18,forceLeftToRight: Bool = false)
+ public init(message: ChatMessage,isFirst: Bool,injectedBackgroundColor: UIColor? = nil,cornerRadius: CGFloat? = nil,forceLeftToRight: Bool = false)
public struct MessageDisplayOptions
- public let showOriginalTranslatedButton: Bool
+ public let reactionsStyle: ReactionsStyle
- public let messageLinkDisplayResolver: @MainActor (ChatMessage) -> [NSAttributedString.Key: Any]
+ public let showOriginalTranslatedButton: Bool
- public let spacerWidth: (CGFloat) -> CGFloat
+ public let messageLinkDisplayResolver: @MainActor (ChatMessage) -> [NSAttributedString.Key: Any]
- public let reactionsTopPadding: (ChatMessage) -> CGFloat
+ public let spacerWidth: (CGFloat) -> CGFloat
- public let dateSeparator: (ChatMessage, ChatMessage) -> Date?
+ public let reactionsTopPadding: (ChatMessage) -> CGFloat
- public static var defaultLinkDisplay: @MainActor (ChatMessage) -> [NSAttributedString.Key: Any]
+ public let dateSeparator: (ChatMessage, ChatMessage) -> Date?
- public static var defaultSpacerWidth: (CGFloat) -> (CGFloat)
+ public static var defaultLinkDisplay: @MainActor (ChatMessage) -> [NSAttributedString.Key: Any]
- public static var defaultReactionsTopPadding: (ChatMessage) -> CGFloat
+ public static var defaultSpacerWidth: (CGFloat) -> (CGFloat)
-
+ public static var defaultReactionsTopPadding: (ChatMessage) -> CGFloat
-
+
- public init(showAvatars: Bool = true,showAvatarsInGroups: Bool? = nil,showMessageDate: Bool = true,showAuthorName: Bool = true,animateChanges: Bool = true,overlayDateLabelSize: CGFloat = 40,lastInGroupHeaderSize: CGFloat = 0,newMessagesSeparatorSize: CGFloat = 50,minimumSwipeGestureDistance: CGFloat = 20,currentUserMessageTransition: AnyTransition = .identity,otherUserMessageTransition: AnyTransition = .identity,shouldAnimateReactions: Bool = true,reactionsPlacement: ReactionsPlacement = .top,showOriginalTranslatedButton: Bool = false,messageLinkDisplayResolver: @escaping @MainActor (ChatMessage) -> [NSAttributedString.Key: Any] = MessageDisplayOptions
+
- .defaultLinkDisplay,spacerWidth: @escaping (CGFloat) -> CGFloat = MessageDisplayOptions.defaultSpacerWidth,reactionsTopPadding: @escaping (ChatMessage) -> CGFloat = MessageDisplayOptions.defaultReactionsTopPadding,dateSeparator: @escaping (ChatMessage, ChatMessage) -> Date? = MessageDisplayOptions.defaultDateSeparator)
+ public init(showAvatars: Bool = true,showAvatarsInGroups: Bool? = nil,showMessageDate: Bool = true,showAuthorName: Bool = true,animateChanges: Bool = true,overlayDateLabelSize: CGFloat = 40,lastInGroupHeaderSize: CGFloat = 0,newMessagesSeparatorSize: CGFloat = 50,minimumSwipeGestureDistance: CGFloat = 20,currentUserMessageTransition: AnyTransition = .identity,otherUserMessageTransition: AnyTransition = .identity,shouldAnimateReactions: Bool = true,reactionsPlacement: ReactionsPlacement = .top,reactionsStyle: ReactionsStyle = .segmented,showOriginalTranslatedButton: Bool = false,messageLinkDisplayResolver: @escaping @MainActor (ChatMessage) -> [NSAttributedString.Key: Any] = MessageDisplayOptions
-
+ .defaultLinkDisplay,spacerWidth: @escaping (CGFloat) -> CGFloat = MessageDisplayOptions.defaultSpacerWidth,reactionsTopPadding: @escaping (ChatMessage) -> CGFloat = MessageDisplayOptions.defaultReactionsTopPadding,dateSeparator: @escaping (ChatMessage, ChatMessage) -> Date? = MessageDisplayOptions.defaultDateSeparator)
-
+
- public func showAvatars(for channel: ChatChannel)-> Bool
+
- public static func defaultDateSeparator(message: ChatMessage,previous: ChatMessage)-> Date?
+ public func showAvatars(for channel: ChatChannel)-> Bool
+ public static func defaultDateSeparator(message: ChatMessage,previous: ChatMessage)-> Date?
public struct MessageBubbleModifier: ViewModifier
- public var cornerRadius: CGFloat
+ public var cornerRadius: CGFloat?
- public init(message: ChatMessage,isFirst: Bool,injectedBackgroundColor: UIColor? = nil,cornerRadius: CGFloat = 18,forceLeftToRight: Bool = false,topPadding: CGFloat = 0,bottomPadding: CGFloat = 0)
+ public init(message: ChatMessage,isFirst: Bool,injectedBackgroundColor: UIColor? = nil,cornerRadius: CGFloat?,forceLeftToRight: Bool = false,topPadding: CGFloat = 0,bottomPadding: CGFloat = 0)
public struct MessageTextView: View
- public init(factory: Factory,message: ChatMessage,isFirst: Bool,leadingPadding: CGFloat = 16,trailingPadding: CGFloat = 16,topPadding: CGFloat = 8,bottomPadding: CGFloat = 8,scrolledId: Binding<String?>)
+ public init(factory: Factory,message: ChatMessage,isFirst: Bool,scrolledId: Binding<String?>)
+ public init(factory: Factory,message: ChatMessage,isFirst: Bool,leadingPadding: CGFloat,trailingPadding: CGFloat,topPadding: CGFloat,bottomPadding: CGFloat,scrolledId: Binding<String?>) |
Collaborator
SDK Size
|
Collaborator
StreamChatSwiftUI XCSize
Show 39 more objects
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Related: IOS-1379
🎯 Goal
Update bubble colors and message text colors
📝 Summary
No icon changes nor localizable string changes in this PR.
🛠 Implementation
🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo