Skip to content

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Oct 31, 2025

Goal

Generate latest code, particularly to get the new models for the activity feedback feature.

Implementation

There were some breaking changes in some models. Two important ones:

  • api.getFollowSuggestions's response now contains a list of FeedSuggestionResponse instead of FeedResponse, so I added the corresponding model and updated the references
  • activities now have an hidden property they didn't have before

Testing

Launch the sample and verify it works, especially the follow suggestions in the profile.

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

@gpunto gpunto requested a review from Copilot October 31, 2025 13:22
@gpunto gpunto added the pr:breaking-change Breaking change label Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SDK to align with API changes related to feed suggestions, moderation actions, and various model properties. The changes introduce new data types and update existing models to better represent the API responses.

  • Introduces FeedSuggestionData wrapper to separate suggestion metadata from feed data
  • Adds support for new moderation action types (block, delete_comment, shadow_block) and activity feedback events
  • Updates model field names and types to match API schema changes (e.g., FeedGroup property names, AppResponseFields structure)

Reviewed Changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ProfileViewModel.kt Maps feed suggestions to extract feed data from the new wrapper type
WSEvent.kt Adds activity feedback event handler
SubmitActionRequest.kt Adds new moderation action types (block, delete_comment, shadow_block)
StoriesFeedUpdatedEvent.kt Swaps interface order and method implementations; adds activities field
ShadowBlockActionRequest.kt Converts from empty class to data class with reason field
ReviewQueueItemResponse.kt Adds latest moderator action and v3 entity fields
PollVote*FeedEvent.kt Swaps interface order and method implementations
ModerationMarkReviewedEvent.kt Swaps interface order and method implementations
GetFollowSuggestionsResponse.kt Changes suggestions type and adds algorithm field
FeedSuggestionResponse.kt New model for feed suggestion response with metadata
FeedMemberRemovedEvent.kt Swaps interface order and method implementations
FeedGroup.kt Updates JSON property names from PascalCase to snake_case
Delete*Request.kt Adds optional reason field to deletion requests
BlockActionRequest.kt Fixes incorrect class definition
AppResponseFields.kt Replaces region/shard with id/placement
Activity*Event.kt Swaps interface order and method implementations
ActivitySelectorConfig.kt Adds cutoff_window field
ActivityResponse.kt Moves hidden field to required and adds preview/moderation_action
ActivityFeedbackRequest.kt Removes fields that were moved to event payload
ActivityFeedback*Payload/Event.kt New models for activity feedback events
Serializer.kt Registers action adapter for feedback payload
Test files Updates tests to use new data structures
FeedSuggestionData.kt New public API model for feed suggestions
FeedSuggestionOperations.kt Conversion logic for feed suggestion responses
Feed.kt Updates return type for queryFollowSuggestions
FeedsRepository*.kt Updates repository interface and implementation
FeedImpl.kt Updates return type for queryFollowSuggestions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-feeds-android-client 2.35 MB 2.36 MB 0.01 MB 🟢

@sonarqubecloud
Copy link

@gpunto gpunto marked this pull request as ready for review October 31, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:breaking-change Breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants