Skip to content

feat: new endpoint for restoring soft deleted activity#221

Merged
dzoke merged 6 commits intomainfrom
zoranmiladinoski/feeds-1117-support-restoring-soft-deleted-activities
Jan 29, 2026
Merged

feat: new endpoint for restoring soft deleted activity#221
dzoke merged 6 commits intomainfrom
zoranmiladinoski/feeds-1117-support-restoring-soft-deleted-activities

Conversation

@dzoke
Copy link
Contributor

@dzoke dzoke commented Jan 28, 2026

🎫 Ticket: https://linear.app/stream/issue/XYZ-123

📑 Docs: https://github.com/GetStream/docs-content/pull/

💡 Overview

📝 Implementation notes

Summary by CodeRabbit

  • New Features

    • Added event handling for restored activities in the feed system, enabling proper recognition and processing of restoration events.
  • Style

    • Code formatting and structure improvements applied for enhanced consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

The change adds support for a new event type 'feeds.activity.restored' by mapping it to a no-op handler in the Feed class, enabling acknowledgment of restored activity events. Minor formatting adjustments were also made to the unfollow method.

Changes

Cohort / File(s) Summary
Event handler for restored activities
packages/feeds-client/src/feed/feed.ts
Added new event mapping 'feeds.activity.restored'Feed.noop to eventHandlers object. Formatting updates applied to unfollow method (line breaks and trailing comma).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 When soft-deleted deeds awake anew,
Feed listens close with quiet virtue,
A gentle noop—no action, no cry,
Just graceful silence passing by! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description follows the template structure but all substantive content sections (Overview and Implementation notes) are empty, providing no meaningful details about the changes. Fill in the Overview section with what the endpoint does and Implementation notes with technical details about how soft-deleted activities are restored and how reactions/comments are handled.
Linked Issues check ❓ Inconclusive The code adds an event handler for 'feeds.activity.restored' but does not demonstrate how reactions and comments relations are preserved during restoration, which was the core requirement in FEEDS-1117. Clarify whether the implementation preserves reactions and comments as required by FEEDS-1117, or if additional changes are needed to address the missing reactions/comments metadata in restored activities.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main feature being added: a new endpoint for restoring soft deleted activities, which matches the primary change.
Out of Scope Changes check ✅ Passed The changes are scoped to adding the event handler for activity restoration and minor formatting updates, which are directly related to the stated objective of supporting soft-deleted activity restoration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • XYZ-123: Entity not found: Issue - Could not find referenced Issue.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

dzoke and others added 5 commits January 28, 2026 16:25
…nmiladinoski/feeds-1117-support-restoring-soft-deleted-activities
…ort-restoring-soft-deleted-activities' into zoranmiladinoski/feeds-1117-support-restoring-soft-deleted-activities
@dzoke dzoke merged commit d23d1e6 into main Jan 29, 2026
6 of 7 checks passed
@dzoke dzoke deleted the zoranmiladinoski/feeds-1117-support-restoring-soft-deleted-activities branch January 29, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants