feat: add feeds.follow.updated handler & cleanup#83
Merged
arnautov-anton merged 2 commits intomainfrom Jul 30, 2025
Merged
Conversation
arnautov-anton
force-pushed
the
feat/follow-state-updated
branch
from
2e36720 to
8081997
Compare
arnautov-anton
commented
Jul 28, 2025
| } from '../../state-updates/state-update-queue'; | ||
| import { isFeedResponse } from '../../type-assertions'; | ||
|
|
||
| export const updateStateFollowDeleted = ( |
Contributor
Author
There was a problem hiding this comment.
@szuperaz - I kept these as there are already tests you wrote for it but I'm going to create a different set of tests for the handleFollowUpdated - we can re-adjust if we don't agree on the approach (I'm going to be following the approach we chose for Thread class in chat).
On a side note; I just moved everything that was related together, I feel like this way it's easier to follow.
arnautov-anton
force-pushed
the
feat/follow-state-updated
branch
from
8081997 to
d874136
Compare
arnautov-anton
commented
Jul 29, 2025
| import { FollowResponse } from '../../gen/models'; | ||
| import { shouldUpdateState } from '../../state-updates/state-update-queue'; | ||
|
|
||
| describe(handleFollowUpdated.name, () => { |
Contributor
Author
There was a problem hiding this comment.
Here's what I had in mind. We could even create a test fixture that'd make the setup much easier and highly reusable.
arnautov-anton
force-pushed
the
feat/follow-state-updated
branch
from
a0467cb to
bffc61b
Compare
arnautov-anton
force-pushed
the
feat/follow-state-updated
branch
from
4c52015 to
7fe04a3
Compare
isekovanic
approved these changes
Jul 30, 2025
szuperaz
approved these changes
Jul 30, 2025
arnautov-anton
force-pushed
the
feat/follow-state-updated
branch
from
7fe04a3 to
7d57f2d
Compare
arnautov-anton
changed the title
feeds.follow.updated handlerfeeds.follow.updated handler & cleanup
arnautov-anton
added a commit
that referenced
this pull request
Aug 4, 2025
### 💡 Overview Forgot to do this in #83 so I'm adding it in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket: https://linear.app/stream/issue/REACT-497
🎫 Ticket: https://linear.app/stream/issue/REACT-483
💡 Overview
handleFollowUpdatedhandlerfeed/event-handlers*private - not publicly exported