Merged
Conversation
sample-apps/react-sample-app/app/components/notifications/NotificationBell.tsx
Outdated
Show resolved
Hide resolved
sample-apps/react-sample-app/app/components/notifications/NotificationFeed.tsx
Outdated
Show resolved
Hide resolved
packages/feeds-client/@react-bindings/hooks/feed-state-hooks/useNotificationStatus.ts
Show resolved
Hide resolved
isekovanic
approved these changes
Aug 18, 2025
Contributor
isekovanic
left a comment
isekovanic
left a comment
There was a problem hiding this comment.
The changes mostly look good to me ! One slight suggestion regarding marking as read, but the other comments are sample app specific so you can ignore them if they aren't valid 🚀
sample-apps/react-sample-app/app/components/notifications/Notification.tsx
Show resolved
Hide resolved
sample-apps/react-sample-app/app/components/notifications/NotificationFeed.tsx
Outdated
Show resolved
Hide resolved
packages/feeds-client/@react-bindings/hooks/feed-state-hooks/useNotificationStatus.ts
Show resolved
Hide resolved
isekovanic
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket: https://linear.app/stream/issue/REACT-463