Merged
Conversation
szuperaz
approved these changes
Jul 31, 2025
Contributor
|
If you have the time, can you please add tests as well? Unit and integration as well? |
arnautov-anton
force-pushed
the
feat/handle-user-updated
branch
from
156a862 to
043598b
Compare
isekovanic
reviewed
Jul 31, 2025
| import type { EventPayload } from '../../../types-internal'; | ||
| import type { FeedsClient, FeedsClientState } from '../../feeds-client'; | ||
|
|
||
| export function handleUserUpdated( |
Contributor
There was a problem hiding this comment.
nitpick
Suggested change
| export function handleUserUpdated( | |
| export handleUserUpdated = ( | |
| this: FeedsClient, | |
| event: EventPayload<'user.updated'>, | |
| ) => |
Contributor
Author
There was a problem hiding this comment.
this acts differently in arrow-type functions, not sure whether that would work.
Contributor
There was a problem hiding this comment.
You shouldn’t need to bind it then, that’s the only thing that should be different I think - but I might be wrong
Contributor
Author
There was a problem hiding this comment.
If it's not using this format then you would not able to access protected properties of the FeedsClient (if we ever need them). I'm just repeating the pattern established for the handlers in Feed.
arnautov-anton
force-pushed
the
feat/handle-user-updated
branch
from
ddeb0a3 to
2cd2213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket: https://linear.app/stream/issue/REACT-512
💡 Overview
feeds-client(as infeed)user.updatedhandler