Skip to content

Commit a61df43

Browse files
authored
chore: fixed timestamp serialization (#116)
1 parent 65abd98 commit a61df43

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

src/BatchOperations.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ private async Task<GenericGetResponse<Activity>> GetActivitiesAsync(IEnumerable<
7575
{
7676
request.AddQueryParameter("foreign_ids", string.Join(",", foreignIdTimes.Select(f => f.ForeignId)));
7777
request.AddQueryParameter("timestamps", string.Join(",", foreignIdTimes.Select(f =>
78-
f.Time.ToString("s", System.Globalization.CultureInfo.InvariantCulture))));
78+
f.Time.ToString("yyyy-MM-dd'T'HH:mm:ss.fff", System.Globalization.CultureInfo.InvariantCulture))));
7979
}
8080

8181
var response = await _client.MakeRequestAsync(request);
@@ -115,7 +115,7 @@ private async Task<GenericGetResponse<EnrichedActivity>> GetEnrichedActivitiesAs
115115
{
116116
request.AddQueryParameter("foreign_ids", string.Join(",", foreignIdTimes.Select(f => f.ForeignId)));
117117
request.AddQueryParameter("timestamps", string.Join(",", foreignIdTimes.Select(f =>
118-
f.Time.ToString("s", System.Globalization.CultureInfo.InvariantCulture))));
118+
f.Time.ToString("yyyy-MM-dd'T'HH:mm:ss.fff", System.Globalization.CultureInfo.InvariantCulture))));
119119
}
120120

121121
options?.Apply(request);

tests/BatchTests.cs

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,5 +285,25 @@ public async Task TestBatchUpdateActivities()
285285
Assert.AreEqual(activity2.Actor, updatedActivity2.Actor);
286286
Assert.AreEqual(activity2.GetData<int[]>("custom"), updatedActivity2.GetData<int[]>("custom"));
287287
}
288+
289+
[Test]
290+
public async Task TestBatchActivityForeignIdTime()
291+
{
292+
var activity = new Activity("user:1", "like", "cake")
293+
{
294+
ForeignId = "cake:1",
295+
Time = DateTime.UtcNow,
296+
Target = "johnny",
297+
};
298+
299+
var insertedActivity = await this.UserFeed.AddActivityAsync(activity);
300+
301+
var foreignIdTime = new ForeignIdTime(insertedActivity.ForeignId, insertedActivity.Time.Value);
302+
IEnumerable<ForeignIdTime> foreignIdTimes = new ForeignIdTime[] { foreignIdTime };
303+
304+
GenericGetResponse<Activity> result = await Client.Batch.GetActivitiesByForeignIdAsync(foreignIdTimes);
305+
306+
Assert.AreEqual(1, result.Results.Count);
307+
}
288308
}
289309
}

0 commit comments

Comments
 (0)