Skip to content

Conversation

@aleksandar-apostolov
Copy link
Contributor

@aleksandar-apostolov aleksandar-apostolov commented Oct 31, 2024

🎯 Goal

Implement a reconnect v2 handling on Android.

🛠 Implementation details

New coordinator and sfu socket implementation.
Refactoring on the RTCSession and Call to better manage the connection state.

Breaking changes

tokenProvider is now a class instead of lambda. To continue using the old implementation use legacyTokenProvider field in the builder.
• Removed Migrating as a RealtimeConnection state. Use Reconnecting instead.
sessionId is no longer available via the StreamVideo instance instead it is available in the Call instance.
• Renamed Call.reconnect to Call.fastReconnect()
• Renamed Call.switchSfu to Call.migrate()

# Conflicts:
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoImpl.kt
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/PersistentSocket.kt
# Conflicts:
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/CoordinatorSocket.kt
# Conflicts:
#	stream-video-android-core/api/stream-video-android-core.api
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/PersistentSocket.kt
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/SfuSocket.kt
# Conflicts:
#	stream-video-android-core/api/stream-video-android-core.api
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/internal/network/NetworkStateProvider.kt
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/utils/AndroidUtils.kt
# Conflicts:
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/PersistentSocket.kt
# Conflicts:
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoImpl.kt
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/utils/DebugInfo.kt
# Conflicts:
#	stream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/StreamCallActivity.kt
# Conflicts:
#	gradle/libs.versions.toml
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/ClientState.kt
#	stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt
@aleksandar-apostolov aleksandar-apostolov marked this pull request as ready for review November 13, 2024 12:02
@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner November 13, 2024 12:02
@aleksandar-apostolov aleksandar-apostolov merged commit 6c06ce4 into develop Nov 15, 2024
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the feature/reconnect-v2 branch November 15, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants