Skip to content

Bugfix/video scaling type #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aleksandar-apostolov merged 3 commits into from
Nov 20, 2024
Merged

Bugfix/video scaling type #1226

aleksandar-apostolov merged 3 commits into from
Nov 20, 2024

Conversation

@aleksandar-apostolov
Copy link
Contributor

@aleksandar-apostolov aleksandar-apostolov commented Nov 19, 2024

🎯 Goal

Fix handling of scaleType for the VideoRenderer

🛠 Implementation details

  1. Remove the fillMaxSize() for the AndroidView modifier.
  2. Add an experimental config API to set the above mentioned and the container (Box) modifier externally.
  3. Add scale type debug menu in order to be able to verify the scale type change.
  4. Propagate the scaleType from the ParticipantVideo downward until the VideoRenderer.

@aleksandar-apostolov
Remove the fillMaxSize() modifier.
99f3526 
Allow setting modifier experimentally from outside. Add debug menu to test the options
@aleksandar-apostolov
Spotless
6bf973c
@aleksandar-apostolov
Api dump
62d706e
@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner November 19, 2024 15:15
skydoves
skydoves approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@aleksandar-apostolov aleksandar-apostolov merged commit 1e26629 into develop Nov 20, 2024
@aleksandar-apostolov aleksandar-apostolov deleted the bugfix/video_scaling_type branch November 20, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skydoves skydoves skydoves approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aleksandar-apostolov @skydoves