[AND-26] Fix sound still audible when device muted issue #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liviu-timar
changed the title
liviu-timar
changed the title
liviu-timar
changed the title
liviu-timar
force-pushed
the
AND-26-fix-sound-audible-when-muted
branch
3 times, most recently
from
8696185 to
51a7ba9
Compare
...orial-livestream/src/main/kotlin/io/getstream/video/android/tutorial/livestream/LiveGuest.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/io/getstream/video/android/core/notifications/internal/service/CallServiceConfig.kt
Outdated
Show resolved
Hide resolved
liviu-timar
commented
Nov 27, 2024
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoBuilder.kt
Show resolved
Hide resolved
liviu-timar
force-pushed
the
AND-26-fix-sound-audible-when-muted
branch
from
01236a5 to
a6f46f4
Compare
aleksandar-apostolov
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix issue that causes sound to still be heard even if device is muted.
🛠 Implementation details
CallServiceConfig#audioUsagewhen building thePeerConnectionFactoryStreamVideoBuilder#audioUsageparameter, which is now ignored. Only the above value should be used.livestreamGuestCallServiceConfig, useMEDIA, which allows muting the sound, as opposed toVOICE_COMMUNICATION.🎉 GIF