[AND-153] ForegroundServiceStartNotAllowedException will now show the notification instead of failing the whole process of starting a service
#1239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tification if the service start fails.
aleksandar-apostolov
changed the title
aleksandar-apostolov
changed the title
ForegroundServiceStartNotAllowedException will now show the notification instead of failing the whole process of starting a service
liviu-timar
reviewed
Dec 3, 2024
Contributor
liviu-timar
left a comment
liviu-timar
left a comment
There was a problem hiding this comment.
Added some comments and a "clean up" commit.
...rc/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt
Show resolved
Hide resolved
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoBuilder.kt
Show resolved
Hide resolved
liviu-timar
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Sometimes starting a foreground service from the notification may fail on higher android versions. In this case we just show the notification and delay the service for when the UI is visible.