Skip to content

Conversation

@rahul-lohra
Copy link
Contributor

  1. Expose CC start and stop Rest Api
  2. Create its response model
  3. Create WS events and map it
  4. Add CaptionManager to handle closed caption related properties

🎯 Goal

Describe why we are making this change

🛠 Implementation details

Describe the implementation

🎨 UI Changes

Add relevant screenshots

Before After
img img

Add relevant videos

Before After

🧪 Testing

Explain how this change can be tested (or why it can't be tested)

Provide a patch below if it is necessary for testing

Provide the patch summary here
Provide the patch code here

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@rahul-lohra rahul-lohra self-assigned this Dec 13, 2024
@rahul-lohra rahul-lohra marked this pull request as ready for review December 16, 2024 10:42
@rahul-lohra rahul-lohra requested a review from a team as a code owner December 16, 2024 10:42
@rahul-lohra rahul-lohra force-pushed the feature/rahullohra/expose_cc_apis branch 6 times, most recently from 6994458 to d09a77a Compare December 17, 2024 13:30
2. Create its response model
3. Create WS events and map it
4. Add CaptionManager to handle cc relates properties
5. Update closedCaptionMode data type in TranscriptionSettingsResponse
6. Add closedCaptionUi argument
7. Update UT
8. Rename variables
9. Expose ClosedCaptionsSettings from Call class
@rahul-lohra rahul-lohra force-pushed the feature/rahullohra/expose_cc_apis branch from c5a8414 to bb7ff51 Compare December 23, 2024 12:53
@aleksandar-apostolov aleksandar-apostolov enabled auto-merge (squash) December 24, 2024 14:22
@aleksandar-apostolov aleksandar-apostolov merged commit 371aed4 into develop Dec 24, 2024
5 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the feature/rahullohra/expose_cc_apis branch December 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants