[AND-21] Closed Caption in demo app #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Create its response model 3. Create WS events and map it 4. Add CaptionManager to handle cc relates properties 5. Update closedCaptionMode data type in TranscriptionSettingsResponse 6. Add closedCaptionUi argument
rahul-lohra
force-pushed
the
feature/rahullohra/closed_caption_demo_app
branch
from
1f2535c to
df1b6cf
Compare
2. Create its response model 3. Create WS events and map it 4. Add CaptionManager to handle cc relates properties 5. Update closedCaptionMode data type in TranscriptionSettingsResponse 6. Add closedCaptionUi argument 7. Update UT
…hra/closed_caption_demo_app
…ure/rahullohra/closed_caption_demo_app
2. Create its response model 3. Create WS events and map it 4. Add CaptionManager to handle cc relates properties 5. Update closedCaptionMode data type in TranscriptionSettingsResponse 6. Add closedCaptionUi argument 7. Update UT 8. Rename variables 9. Expose ClosedCaptionsSettings from Call class
…hra/closed_caption_demo_app # Conflicts: # stream-video-android-core/api/stream-video-android-core.api # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallState.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/closedcaptions/ClosedCaptionManager.kt
…n_demo_app' into feature/rahullohra/closed_caption_demo_app
…hra/closed_caption_demo_app
…to follow SDK guidelines" This reverts commit d369c6f.
…hra/closed_caption_demo_app
…hra/closed_caption_demo_app
…hra/closed_caption_demo_app
…ion_demo_app # Conflicts: # stream-video-android-core/api/stream-video-android-core.api
aleksandar-apostolov
approved these changes
Dec 24, 2024
…n_demo_app' into feature/rahullohra/closed_caption_demo_app
aleksandar-apostolov
deleted the
feature/rahullohra/closed_caption_demo_app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Implement Closed captions in demo app
Describe why we are making this change
🛠 Implementation details
Describe the implementation
Please look here: https://link.excalidraw.com/l/3pA6EEutKdi/3MEczcJqlaE
🎨 UI Changes
Add relevant screenshots
Add relevant videos
🧪 Testing
Explain how this change can be tested (or why it can't be tested)
Provide a patch below if it is necessary for testing
Provide the patch summary here
☑️Contributor Checklist
General
developbranchCode & documentation
stream-video-examples)☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request