Skip to content

Conversation

@liviu-timar
Copy link
Contributor

@liviu-timar liviu-timar commented Dec 20, 2024

🎯 Goal

Fix issue: when peer reconnects, sometimes the video feed doesn't recover.

🛠 Implementation details

The problem proved to be ICE related: AddIceCandidate: ICE candidates can't be added without any remote session description.

Solution:

  • Store received ICE candidates if the remote description is null.
  • Add ICE candidates once the remote description is set.
  • Synchronize resource access.

@liviu-timar liviu-timar requested a review from a team as a code owner December 20, 2024 10:13
@aleksandar-apostolov aleksandar-apostolov enabled auto-merge (squash) December 20, 2024 10:43
@aleksandar-apostolov aleksandar-apostolov merged commit 5e75aa2 into develop Dec 20, 2024
5 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the reconnect-fix branch December 20, 2024 10:47
@liviu-timar liviu-timar changed the title [AND 189] Fix issue: when reconnecting, video feed doesn't recover [AND-189] Fix issue: when reconnecting, video feed doesn't recover Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants