Skip to content

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Nov 7, 2025

Goal

AND-880

As the title says.

Note: I'm not running spotlessApply here to avoid bundling the migration with all the Spotless changes. I'll do it in a follow up. What will change is the XML header because it was different.

Implementation

Replace local Spotless configuration with the convention.

🎨 UI Changes

None

Testing

Run spotlessApply and verify that the files are updated accordingly.

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs
  • Check the SDK Size Comparison table in the CI logs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@gpunto gpunto added the pr:internal Internal or infra-only changes label Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.93 MB 11.93 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.27 MB 6.27 MB 0.00 MB 🟢

@gpunto gpunto mentioned this pull request Nov 7, 2025
21 tasks
@gpunto gpunto force-pushed the plugins.spotless branch 2 times, most recently from 35dabfd to 5841b10 Compare November 11, 2025 11:26
@gpunto gpunto marked this pull request as ready for review November 14, 2025 12:31
@gpunto gpunto requested a review from a team as a code owner November 14, 2025 12:31
@sonarqubecloud
Copy link

@gpunto gpunto enabled auto-merge (squash) November 24, 2025 12:24
Copy link
Contributor

@rahul-lohra rahul-lohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gpunto gpunto disabled auto-merge November 25, 2025 14:10
@gpunto gpunto merged commit fb588a2 into develop Nov 25, 2025
15 of 17 checks passed
@gpunto gpunto deleted the plugins.spotless branch November 25, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:internal Internal or infra-only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants