-
Notifications
You must be signed in to change notification settings - Fork 56
Add possibility to share screen audio when screensharing is enabled #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… audio screen sharing is present 2. If the user was muted while screen sharing, stopping screen sharing properly unpublishes the audio stream and sets the mute state.
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
PratimMallick
commented
Nov 12, 2025
demo-app/src/main/kotlin/io/getstream/video/android/ui/call/CallScreen.kt
Outdated
Show resolved
Hide resolved
rahul-lohra
approved these changes
Nov 13, 2025
Contributor
rahul-lohra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Contributor
|
We are not yet merging this, as there are some discussions around SFU changes. |
…audio while screensharing
aleksandar-apostolov
approved these changes
Nov 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Goal
This PR adds support for capturing and transmitting screen audio during screen sharing on Android. Previously, when users shared their screen, only the video was transmitted. This change enables capturing system audio (e.g., from media playback, other apps) and mixing it with microphone audio before transmission.
Please note that the screen audio is not send if user mutes their microphone since the local audio track is unpublished when muting.
Implementation
Screen Audio Capture:
AudioRecordwithAudioPlaybackCaptureConfiguration(Android Q+)AudioRecordusingREAD_BLOCKINGmodeAudio Mixing:
addAndConvertBuffers()utility function to mix microphone and screen audio buffersStreamPeerConnectionFactory.setAudioBufferCallback():Audio Track Management:
includeAudioparameter toCall.startScreenSharing()(defaults tofalse)audioEnabledStateFlow toScreenShareManagerto track screen share audio state separately from videoKey Changes:
MediaManager.ScreenShareManager: Added screen audio capture infrastructure andaudioEnabledStateFlowStreamPeerConnectionFactory: Added audio mixing logic with proper filter application orderincludeAudio=truewhen starting screen sharing🎨 UI Changes
None
Testing
On the demo app :
includeAudio=trueand verify system audio is captured and transmitted