Skip to content

Introduce Join-Then-Ring Mechanism for Individual Call Members #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aleksandar-apostolov merged 9 commits into from
Nov 20, 2025
Merged

Introduce Join-Then-Ring Mechanism for Individual Call Members #1574

aleksandar-apostolov merged 9 commits into from
Nov 20, 2025

Conversation

@rahul-lohra
Copy link
Contributor

@rahul-lohra rahul-lohra commented Nov 20, 2025 •
edited
Loading

Goal

Introduce Join-Then-Ring Mechanism for Individual Call Members

Implementation

Introduce 2 public apis

Class Methods
Call suspend fun joinAndRing(members:List, createOptions: CreateCallOptions, video: Boolean): Result
Call fun ring(ringCallRequest: RingCallRequest): Result

Testing

  1. Tick the checkbox on Direct Call Screen to use JoinAndRing Mechanism
  2. Caller should be rendering outgoing call screen
  3. After call is picked up then rest of thing should work as usual

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025 •
edited
Loading

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.91 MB 11.93 MB 0.02 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.25 MB 6.27 MB 0.02 MB 🟢

@rahul-lohra rahul-lohra self-assigned this Nov 20, 2025
@rahul-lohra rahul-lohra changed the title [wip] ring individual members Add API to Join Call and Ring Individual Members Nov 20, 2025
@rahul-lohra rahul-lohra marked this pull request as ready for review November 20, 2025 14:45
@rahul-lohra rahul-lohra requested a review from a team as a code owner November 20, 2025 14:45
@rahul-lohra rahul-lohra added the pr:new-feature Adds new functionality label Nov 20, 2025
@rahul-lohra rahul-lohra changed the title Add API to Join Call and Ring Individual Members Introduce Join-Then-Ring Mechanism for Individual Call Members Nov 20, 2025
@rahul-lohra rahul-lohra changed the title Introduce Join-Then-Ring Mechanism for Individual Call Members [AND-899] Introduce Join-Then-Ring Mechanism for Individual Call Members Nov 20, 2025
@rahul-lohra rahul-lohra changed the title [AND-899] Introduce Join-Then-Ring Mechanism for Individual Call Members Introduce Join-Then-Ring Mechanism for Individual Call Members Nov 20, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 20, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
12.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit 429c751 into develop Nov 20, 2025
15 of 18 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the feature/rahullohra/ring-individual-members branch November 20, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees

@rahul-lohra rahul-lohra

Labels

pr:new-feature Adds new functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahul-lohra @aleksandar-apostolov