Configure coverage through common convention plugins #1575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the project from custom coverage and publishing configuration scripts to Stream's convention plugins (version 0.4.0). The changes centralize build configuration and simplify the project structure.
Key Changes:
- Migrated from custom Gradle scripts to Stream convention plugins for coverage, publishing, and code formatting
- Updated from spotless custom configuration to convention plugin-based approach
- Replaced manual Maven publishing setup with vanniktech/maven-publish plugin
- Standardized copyright headers across XML files (updated year range to 2014-2024 and normalized formatting)
Reviewed changes
Copilot reviewed 182 out of 188 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build.gradle.kts | Migrated to stream-project plugin, configured coverage and spotless settings, replaced custom publish scripts with maven-publish plugin setup |
| gradle/libs.versions.toml | Updated streamConventions to 0.4.0, added maven-publish plugin, removed kover/sonarqube/nexus plugins |
| build-logic/convention/* | Removed SpotlessConventionPlugin, added DemoFlavorConventionPlugin |
| stream-video-android-*/build.gradle.kts | Updated all library modules to use maven-publish plugin with AndroidSingleVariantLibrary configuration |
| tutorials/*/build.gradle.kts | Removed spotless plugin references, cleaned up suppressions |
| demo-app/build.gradle.kts | Applied demoflavor convention plugin, removed manual flavor configuration |
| benchmark/build.gradle.kts | Switched to stream.android.test plugin, applied demoflavor convention |
| scripts/*.gradle | Removed custom publish, coverage, and sonar scripts (migrated to plugins) |
| spotless/copyright.* | Removed copyright template files (now handled by convention plugin) |
| **/*.xml | Updated copyright headers: year range and formatting normalization |
| .github/workflows/*.yml | Updated publish workflows to use new maven-publish plugin environment variables |
Files not reviewed (5)
- tutorials/tutorial-audio/.idea/gradle.xml: Language not supported
- tutorials/tutorial-audio/.idea/misc.xml: Language not supported
- tutorials/tutorial-livestream/.idea/gradle.xml: Language not supported
- tutorials/tutorial-livestream/.idea/misc.xml: Language not supported
- tutorials/tutorial-livestream/.idea/workspace.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
gpunto
changed the title
gpunto
force-pushed
the
plugins.spotless.apply
branch
from
20685d2 to
0b166b2
Compare
gpunto
changed the title
gpunto
force-pushed
the
plugins.coverage
branch
from
c6e8048 to
ae189b6
Compare
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
gpunto
commented
Nov 27, 2025
...ndroid-previewdata/src/main/kotlin/io/getstream/video/android/mock/StreamPreviewDataUtils.kt
Show resolved
Hide resolved
aleksandar-apostolov
approved these changes
Nov 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
AND-892
As the title says, we're moving to the common coverage convention instead of configuring it in here.
Implementation
Remove the custom coverage configuration logic and rely on the plugins
🎨 UI Changes
None
Testing
Coverage should be reported correctly to Sonar
☑️Contributor Checklist
General
developbranchCode & documentation
stream-video-examples)☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request