Skip to content

Conversation

@rahul-lohra
Copy link
Contributor

@rahul-lohra rahul-lohra commented Nov 26, 2025

Goal

Improve RtcSession Creation Logic: Handle Errors Gracefully

Implementation

Wrap RtcSession instace creation inside try-catch

Testing

To reproduce the error follow the steps

  1. Write call.cleanup() on the first line inside call.join()
  2. Start a new call in demo-app
  3. The demo-app should not crash

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.93 MB 11.93 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.70 MB 5.70 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.27 MB 6.27 MB 0.00 MB 🟢

@rahul-lohra rahul-lohra self-assigned this Nov 27, 2025
@rahul-lohra rahul-lohra changed the title Improve RtcSession Creation Logic: Handle Errors Gracefully [AND-930] Improve RtcSession Creation Logic: Handle Errors Gracefully Nov 27, 2025
@rahul-lohra rahul-lohra added pr:bug Fixes a bug pr:improvement Enhances an existing feature or code and removed pr:bug Fixes a bug labels Nov 27, 2025
@rahul-lohra rahul-lohra marked this pull request as ready for review November 27, 2025 09:26
@rahul-lohra rahul-lohra requested a review from a team as a code owner November 27, 2025 09:26
@rahul-lohra rahul-lohra changed the title [AND-930] Improve RtcSession Creation Logic: Handle Errors Gracefully Improve RtcSession Creation Logic: Handle Errors Gracefully Nov 27, 2025
Copy link
Contributor

@PratimMallick PratimMallick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also take this opportunity to move the creation of RTCSession logic to one place/method rather than have it at 3 places . Easier readability and less lines

@aleksandar-apostolov
Copy link
Contributor

Refactoring the call / state / RTCSession is part of another topic, lets just fix this here.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit 560d163 into develop Nov 28, 2025
19 of 22 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the bugfix/rahullohra/call-cleanup-crash branch November 28, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Enhances an existing feature or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants