-
Notifications
You must be signed in to change notification settings - Fork 56
Improve RtcSession Creation Logic: Handle Errors Gracefully #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve RtcSession Creation Logic: Handle Errors Gracefully #1576
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
PratimMallick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also take this opportunity to move the creation of RTCSession logic to one place/method rather than have it at 3 places . Easier readability and less lines
|
Refactoring the call / state / RTCSession is part of another topic, lets just fix this here. |
|


Goal
Improve RtcSession Creation Logic: Handle Errors Gracefully
Implementation
Wrap
RtcSessioninstace creation inside try-catchTesting
To reproduce the error follow the steps
call.cleanup()on the first line insidecall.join()