Skip to content

Conversation

@aleksandar-apostolov
Copy link
Contributor

Goal

To correctly sort participants based on source.

Implementation

Re-arranged order of SIP participant

Testing

Join via OBS and via pronto and see the OBS participant sorted before the WebRTC participant.

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner November 27, 2025 08:14
@aleksandar-apostolov aleksandar-apostolov added the pr:improvement Enhances an existing feature or code label Nov 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@aleksandar-apostolov aleksandar-apostolov changed the title update participant source Update participant sorting order based on source Nov 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.93 MB 11.93 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.70 MB 5.70 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.27 MB 6.27 MB 0.00 MB 🟢

Copy link
Contributor

@rahul-lohra rahul-lohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

@aleksandar-apostolov aleksandar-apostolov merged commit cf87035 into develop Nov 28, 2025
16 of 17 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the updated-participants-sort branch November 28, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Enhances an existing feature or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants