Skip to content

Conversation

@aleksandar-apostolov
Copy link
Contributor

@aleksandar-apostolov aleksandar-apostolov commented Dec 15, 2025

Goal

AND-956

Fix an issue where Android SDK may end up in a reconnect loop.

Implementation

Do not create the publisher peer connection if there is no capability to publish anything. The reason for this is that in certain scenario when fast reconnecting the publisher will send an empty SetPublisher which will be rejected pushing the SDK into a loop of reconnects. To avoid this we simply do not initialize the publisher if we do not have capability to publish.

Testing

Run unit tests. Do smoke test and sanity checks.

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner December 15, 2025 16:06
@aleksandar-apostolov aleksandar-apostolov changed the title Bugfix/setpublisher call Fix an issue where Android SDK may end up in a reconnect loop Dec 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@aleksandar-apostolov aleksandar-apostolov added the pr:bug Fixes a bug label Dec 15, 2025
@github-actions
Copy link
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.94 MB 11.94 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.27 MB 6.27 MB 0.00 MB 🟢

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov changed the title Fix an issue where Android SDK may end up in a reconnect loop [AND-956] Fix an issue where Android SDK may end up in a reconnect loop Dec 16, 2025
@aleksandar-apostolov aleksandar-apostolov merged commit b44f0c9 into develop Dec 16, 2025
20 of 24 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the bugfix/setpublisher-call branch December 16, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bug Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants