-
Notifications
You must be signed in to change notification settings - Fork 46
fix(llc): fix android audio configuration setup #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughApply Android-specific WebRTC audio configuration during CallSession.start(): after rtcManager initialization, call rtc.Helper.setAndroidAudioConfiguration when androidAudioConfiguration is provided; failures are caught and logged without aborting startup. Also update CHANGELOG with the fix note. Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant CallSession
participant RTCManager
participant RTC_Helper as rtc.Helper
participant Logger
App->>CallSession: start()
CallSession->>RTCManager: create/init
alt Android AND androidAudioConfiguration != null
CallSession->>RTC_Helper: setAndroidAudioConfiguration(config)
Note over CallSession,RTC_Helper: Apply before proceeding with rest of start
opt Failure
RTC_Helper-->>CallSession: throws
CallSession->>Logger: warn("Failed to apply Android audio config")
Note over CallSession: Continue without aborting
end
end
CallSession-->>App: start() continues
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
========================================
- Coverage 4.85% 4.84% -0.01%
========================================
Files 591 591
Lines 40162 40168 +6
========================================
Hits 1948 1948
- Misses 38214 38220 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR fixes and issue where custom Android audio configuration could not be applied correctly for participants joining the call.
Summary by CodeRabbit