Skip to content

fix(llc): revert audio session release#1190

Merged
Brazol merged 3 commits intomainfrom
fix/revert-audio-session-release-ios
Mar 17, 2026
Merged

fix(llc): revert audio session release#1190
Brazol merged 3 commits intomainfrom
fix/revert-audio-session-release-ios

Conversation

@Brazol
Copy link
Contributor

@Brazol Brazol commented Mar 17, 2026

This PR reverts the changes introduced in #1155 following reports that they caused issues in certain iOS scenarios. The changes will remain reverted until further investigation determines why they lead to problems in newly created calls.

Summary by CodeRabbit

  • Bug Fixes
    • Reverted a recent change to iOS call cleanup that caused broken audio playout. Restored prior audio session behavior so iOS devices no longer lose playback when leaving calls.

@Brazol Brazol requested a review from a team as a code owner March 17, 2026 10:38
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e6ab030e-281b-4f0a-b3a2-8544c4866f05

📥 Commits

Reviewing files that changed from the base of the PR and between aa1d347 and d6d6a6d.

📒 Files selected for processing (2)
  • packages/stream_video/CHANGELOG.md
  • packages/stream_video/lib/src/webrtc/rtc_manager.dart
💤 Files with no reviewable changes (1)
  • packages/stream_video/lib/src/webrtc/rtc_manager.dart
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/stream_video/CHANGELOG.md

📝 Walkthrough

Walkthrough

This change reverts the iOS-specific audio session release on call leave: the CHANGELOG records the revert, and the RtcManager.dispose implementation no longer calls pauseAudioPlayout or its try-catch error handling for iOS.

Changes

Cohort / File(s) Summary
Changelog
packages/stream_video/CHANGELOG.md
Added an Upcoming Fixed entry noting the revert of releasing the iOS audio session on call leave due to broken audio playout reports.
iOS audio cleanup removal
packages/stream_video/lib/src/webrtc/rtc_manager.dart
Removed iOS-only dispose logic that invoked pauseAudioPlayout and its surrounding try-catch; disposal no longer triggers that audio playout pause side effect.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped through lines, made one small mend,

Removed a pause so playback won't end,
A tiny revert, sound kept in tune,
I celebrate with carrot and moon. 🥕🎶

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required sections from the template (Goal, Implementation details, Testing, and Contributor Checklist) and provides minimal detail about the revert. Add Goal, Implementation details, and Testing sections. At minimum, explain what was reverted and why, then fill the Contributor Checklist.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: reverting audio session release for iOS, which directly relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/revert-audio-session-release-ios
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Brazol Brazol linked an issue Mar 17, 2026 that may be closed by this pull request
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/stream_video/CHANGELOG.md (1)

4-4: Use the revert PR link for release-note traceability.

This line currently links only to #1155 (the original change), but this changelog entry documents the revert in #1190. Please link #1190 explicitly (optionally keep #1155 as “reverted change from …”) so readers can jump to the actual fix PR.

Proposed wording
-* Reverted iOS audio session release on call leave ([`#1155`](https://github.com/GetStream/stream-video-flutter/pull/1155)) due to reports of broken audio playout on some iOS sessions.
+* Reverted iOS audio session release on call leave in [`#1190`](https://github.com/GetStream/stream-video-flutter/pull/1190), reverting behavior introduced in [`#1155`](https://github.com/GetStream/stream-video-flutter/pull/1155), due to reports of broken audio playout on some iOS sessions.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/stream_video/CHANGELOG.md` at line 4, Update the changelog entry
string that currently references only PR `#1155` to explicitly reference the
revert PR `#1190` for traceability; modify the line in CHANGELOG.md (the entry "*
Reverted iOS audio session release on call leave ([`#1155`](...)) due to reports
of broken audio playout on some iOS sessions.") to include a link to `#1190` (and
optionally keep `#1155` noted as "reverted change from `#1155`") so readers can jump
directly to the actual revert PR.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/stream_video/CHANGELOG.md`:
- Line 4: Update the changelog entry string that currently references only PR
`#1155` to explicitly reference the revert PR `#1190` for traceability; modify the
line in CHANGELOG.md (the entry "* Reverted iOS audio session release on call
leave ([`#1155`](...)) due to reports of broken audio playout on some iOS
sessions.") to include a link to `#1190` (and optionally keep `#1155` noted as
"reverted change from `#1155`") so readers can jump directly to the actual revert
PR.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6074a836-78c3-48ae-87ae-4f09d3799a30

📥 Commits

Reviewing files that changed from the base of the PR and between 45519e3 and aa1d347.

📒 Files selected for processing (2)
  • packages/stream_video/CHANGELOG.md
  • packages/stream_video/lib/src/webrtc/rtc_manager.dart
💤 Files with no reviewable changes (1)
  • packages/stream_video/lib/src/webrtc/rtc_manager.dart

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 6.42%. Comparing base (8e9bc0d) to head (d6d6a6d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1190   +/-   ##
=====================================
  Coverage   6.42%   6.42%           
=====================================
  Files        615     615           
  Lines      43412   43409    -3     
=====================================
  Hits        2788    2788           
+ Misses     40624   40621    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Brazol Brazol merged commit 633cf9b into main Mar 17, 2026
16 checks passed
@Brazol Brazol deleted the fix/revert-audio-session-release-ios branch March 17, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS calls are muted since 1.2.3

2 participants