fix: use worker to prevent timer throttling #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myandrienko
commented
Dec 3, 2024
| * Create Web Worker to initiate timer events like health checks. Can possibly prevent | ||
| * timer throttling issues in inactive browser tabs. | ||
| */ | ||
| expertimental_enableTimerWorker?: boolean; |
oliverlaz
approved these changes
Dec 3, 2024
myandrienko
added a commit
that referenced
this pull request
Dec 11, 2024
Dropping the `experimental_` prefix since this feature was confirmed working. Since the timer worker (introduced in #1557) is not going to be updated too often, we can skip an additional built step and just check in the prebuilt worker. The "source" file `worker.ts` and the script to generate worker are still there, but they are not used during build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers start throttling timers (intervals, timeouts) in background tabs after a period of inactivity. We use timers to send health checks, and missing health checks cause participant to be disconnected.
An active WebRTC connection on a page usually means the page is never considered inactive by the browser, and therefore timers are not throttled. But it's still possible to be in a call and not have an active connection, e.g. if nobody is publishing neither audio nor video. Also, some browsers (like Edge) might be more aggressive about timer throttling.
To handle situations like this, we move timers to a web worker, which are never throttled. Web worker then posts messages to the page on the specified intervals.
This feature is currently opt-in and hidden behind a feature toggle, which can be enabled when creating a client instance. Also, web workers might not be available (banned by CSP, running on Node, etc), so there's also a fallback mode that uses regular timers on the page side even when enabled.