fix: do not mute track on camera flip#1671
Merged
santhoshvai merged 7 commits intomainfrom Feb 5, 2025
Merged
Conversation
santhoshvai
changed the title
myandrienko
reviewed
Feb 4, 2025
| // web mobile | ||
| this.state.setDirection(direction); | ||
| // Providing both device id and direction doesn't work, so we deselect the device | ||
| this.state.setDevice(undefined); |
Contributor
There was a problem hiding this comment.
I think this should go outside of this if.
| videoTrack._switchCamera(); | ||
| } else { | ||
| const constraints = { | ||
| facingMode: direction === 'front' ? 'user' : 'environment', |
Contributor
There was a problem hiding this comment.
Should we add ...this.constraints here? Otherwise we lose target resolution constraint.
Member
Author
There was a problem hiding this comment.
for RN it is unnecessary, the native lib stores the old resoltion constriants..
myandrienko
reviewed
Feb 4, 2025
| }; | ||
| videoTrack.applyConstraints(constraints); | ||
| } | ||
| this.state.setDirection(direction); |
Contributor
There was a problem hiding this comment.
Since setMediaStream is not called in this case, there's a slight change of behavior: deviceId is not set to an actual deviceId from track settings. I don't know if it's important for RN though.
Member
Author
There was a problem hiding this comment.
it is not necessary for RN, the change of camera deviceId happens under the hood, it just takes index values internally
myandrienko
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This change avoids sending mute to SFU when camera is flipped -- this makes flip faster
React Native
The avatar image wont be shown at all, as track is flipped internally
Untitled.mov
React - web mobile
We stop previous track. do not send mute signal to SFU now. We momentarily see the avatar.
screen-20250204-114443.mp4