fix: ensure tracks are stopped when disposing a Publisher#1676
Merged
fix: ensure tracks are stopped when disposing a Publisher#1676
Conversation
myandrienko
approved these changes
Feb 7, 2025
oliverlaz
added a commit
that referenced
this pull request
Feb 10, 2025
Continuation on #1676. We were still leaking tracks in iOS Safari. ### Implementation notes Aggressively keep track of cloned tracks in Publisher and ensure all of them are stopped when it is disposed of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In some circumstances, we were dangling track clones. No data flowed to the SFU, but the browser kept the camera/mic indicators on as there were MediaStreamTrack instances that weren't stopped properly.
Implementation notes
Upon disposing of a
Publisher, we now iterate through all transceivers and we explicitly stop the assigned track.This PR also fixes another issue that could lead to dangling, unstopped tracks when replacing a track on an existing transceiver.