fix: warn natively if notifee is not configured for keep call alive#1678
Merged
santhoshvai merged 4 commits intomainfrom Feb 12, 2025
Merged
fix: warn natively if notifee is not configured for keep call alive#1678santhoshvai merged 4 commits intomainfrom
santhoshvai merged 4 commits intomainfrom
Conversation
oliverlaz
reviewed
Feb 10, 2025
Comment on lines
44
to
45
| // Package not found (shouldn't happen for the current app) | ||
| e.printStackTrace() |
Member
There was a problem hiding this comment.
This is a bad practice. How can we better handle this exception?
Member
Author
There was a problem hiding this comment.
made it better by adding a better logger
but this is not bad practice I think. Atleast I do not know. This catch block was autogenerated by android studio. So I do not think so 😆
packages/react-native-sdk/src/hooks/useAndroidKeepCallAliveEffect.ts
Outdated
Show resolved
Hide resolved
oliverlaz
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1587
Now even if notifee is installed, but not configured properly, we skip call alive part from SDK..
upon inspecting native logs they can see whats not configured properly, its on warn level for easiness