fix: early completion call on iOS remote notifications#1687
Merged
santhoshvai merged 3 commits intomainfrom Feb 19, 2025
Merged
fix: early completion call on iOS remote notifications#1687santhoshvai merged 3 commits intomainfrom
santhoshvai merged 3 commits intomainfrom
Conversation
santhoshvai
commented
Feb 19, 2025
Member
Author
There was a problem hiding this comment.
this is unrelevant to this PR, but aims to fix a confusion here, useEffect now captures the last count by reference to make it clear.
It doesn't cause any difference though
oliverlaz
approved these changes
Feb 19, 2025
kristian-mkd
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
rarely didDisplayIncomingCall comes after onNotificationReceived completes, this is problematic as per the voipNotification library. We must complete only at the last after all are processed it seems.
But I dont know what the problem is though.
Test
Just ensure that JS calls the completion function in all three scenarios