fix: make camera.flip() work more reliably with older devices#1781
Merged
fix: make camera.flip() work more reliably with older devices#1781
Conversation
oliverlaz
requested review from
Copilot,
kristian-mkd,
myandrienko and
santhoshvai
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix a regression in camera.flip() for older devices by adding a fallback mechanism when a fast direction change fails. Key changes include:
- Early exit if the device doesn't support direction changes.
- Separating logic for React Native and web mobile.
- Adding error handling to recover from NotReadableError via a stop–start (mute–unmute) flow.
kristian-mkd
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Overview
While optimizing the
camera.flip()API in #1679, we introduced a regression that led tocamera.flip()throwing aNotReadableErroron devices with limited hardware capabilities.Some devices are unable to provide two
MediaStreaminstances at the same time.📝 Implementation notes
We want to preserve the
camera.flip()optimizations as they allow significantly faster direction change.We always attempt to perform a fast direction change, but if it fails, we fall back to:
stop()->flip()->start()flow, which is slower, but it works.🎫 Ticket: https://linear.app/stream/issue/REACT-367/