Skip to content

fix: don't use token provider for pronto-sales #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: don't use token provider for pronto-sales #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff1311c
fix: don't use token provider for pronto-sales
myandrienko Sep 2, 2025
18536d3
add 404 for create-token endpoint
myandrienko Sep 2, 2025
3ead088
Merge branch 'main' into fix/no-token-provider-sales
myandrienko Sep 4, 2025
f7c5657
chore: enable preview deployments for pronto-sales
oliverlaz Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-react-sample-apps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:

### Vercel deployment (Preview) ###
- name: Vercel Pull/Build/Deploy (Preview)
if: ${{ github.ref_name != 'main' && matrix.application.manual-only != true }}
if: ${{ github.ref_name != 'main' }}
env:
NEXT_PUBLIC_BASE_PATH: ${{ matrix.application.base-path || '' }}
run: >
Expand Down
12 changes: 10 additions & 2 deletions sample-apps/react/react-dogfood/helpers/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,15 @@ export const getClient = (

const basePath = process.env.NEXT_PUBLIC_BASE_PATH || '';

export const createTokenProvider =
(userId: string | undefined, environment: AppEnvironment) => async () => {
export const createTokenProvider = (
userId: string | undefined,
environment: AppEnvironment,
) => {
if (process.env.NEXT_PUBLIC_APP_ENVIRONMENT === 'pronto-sales') {
return undefined;
}

return async () => {
const params = new URLSearchParams({
user_id: userId || '!anon',
environment,
Expand All @@ -58,3 +65,4 @@ export const createTokenProvider =
const json = await ((await res.json()) as Promise<CreateJwtTokenResponse>);
return json.token;
};
};
4 changes: 4 additions & 0 deletions sample-apps/react/react-dogfood/pages/api/auth/create-token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ const createJwtToken = async (
req: NextApiRequest,
res: NextApiResponse<CreateJwtTokenResponse | CreateJwtTokenErrorResponse>,
) => {
if (process.env.NEXT_PUBLIC_APP_ENVIRONMENT === 'pronto-sales') {
return error(res, 'This endpoint is not enabled', 404);
}

const {
user_id: userId,
api_key: apiKeyFromRequest,
Expand Down