Closed
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required. |
Generated by 🚫 Danger |
Public Interface+ public enum WebRTCJoinPolicy: Sendable
+
+ case `default`
+ case peerConnectionReadinessAware(timeout: TimeInterval)
+ public final class TimeOutError: ClientError, Sendable
public class Call: @unchecked Sendable, WSEventsSubscriber
- @MainActor public internal var state
+ @MainActor public internal var state: CallState
- @discardableResult public func join(create: Bool = false,options: CreateCallOptions? = nil,ring: Bool = false,notify: Bool = false,callSettings: CallSettings? = nil)async throws -> JoinCallResponse
+ @discardableResult public func join(create: Bool = false,options: CreateCallOptions? = nil,ring: Bool = false,notify: Bool = false,callSettings: CallSettings? = nil,policy: WebRTCJoinPolicy = .default)async throws -> JoinCallResponse |
|
Build for regression testing №323 has been uploaded to TestFlight 🎁 |
Collaborator
Author
SDK Size
|
Collaborator
Author
StreamVideo XCSize
Show 118 more objects
|
Collaborator
Author
StreamVideoSwiftUI XCSize
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Added
WebRTCJoinPolicytoCall.join()so applications can delay joincompletion until publisher and subscriber peer connections are ready.
🔄 Changed
sessions instead of swallowing them after logging. #1072
CallViewModelnow waits briefly for peer-connection readiness before an accepted ringing call is surfaced as joined. #1080🐞 Fixed
callEndedonly after active/ringing cleanupand keep
CallSessiontoken values in sync withStreamVideotoken updates. #1071deviceTokenon the main actor to avoid Swift concurrency/actor-isolation issues. #1076CallViewModelinto.joiningbefore the call finishes entering, so the joining UI appears immediately. #1079