-
Notifications
You must be signed in to change notification settings - Fork 28
Fix PiP UI issues on iOS 26 #909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| // | ||
| // Copyright © 2025 Stream.io Inc. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// A configuration object that defines padding values for different edges. | ||
| /// | ||
| /// `PaddingsConfig` allows you to specify custom padding values for leading, | ||
| /// trailing, top, and bottom edges, which can be reused across multiple UI components. | ||
| public struct PaddingsConfig { | ||
martinmitrevski marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /// The amount of padding on the leading edge. | ||
| public let leading: CGFloat | ||
|
|
||
| /// The amount of padding on the trailing edge. | ||
| public let trailing: CGFloat | ||
|
|
||
| /// The amount of padding on the top edge. | ||
| public let top: CGFloat | ||
|
|
||
| /// The amount of padding on the bottom edge. | ||
| public let bottom: CGFloat | ||
|
|
||
| /// Creates a new `PaddingsConfig` instance with the specified edge paddings. | ||
| /// | ||
| /// - Parameters: | ||
| /// - leading: The padding for the leading edge. Defaults to `0`. | ||
| /// - trailing: The padding for the trailing edge. Defaults to `0`. | ||
| /// - top: The padding for the top edge. Defaults to `0`. | ||
| /// - bottom: The padding for the bottom edge. Defaults to `0`. | ||
| public init( | ||
| leading: CGFloat = 0, | ||
| trailing: CGFloat = 0, | ||
| top: CGFloat = 0, | ||
| bottom: CGFloat = 0 | ||
| ) { | ||
| self.leading = leading | ||
| self.trailing = trailing | ||
| self.top = top | ||
| self.bottom = bottom | ||
| } | ||
| } | ||
|
|
||
| extension PaddingsConfig { | ||
|
|
||
| /// Padding configuration for the participant info view. | ||
| /// | ||
| /// - Leading: `6` | ||
| /// - Trailing: `6` | ||
| /// - Top: `2` | ||
| /// - Bottom: `2` | ||
| @MainActor public static let participantInfoView = PaddingsConfig( | ||
martinmitrevski marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| leading: 6, | ||
| trailing: 6, | ||
| top: 2, | ||
| bottom: 2 | ||
| ) | ||
|
|
||
| /// Padding configuration for the participant info view in Picture-in-Picture mode. | ||
| /// | ||
| /// The leading and bottom paddings vary depending on the iOS version. | ||
| @MainActor public static let participantInfoViewPiP = PaddingsConfig( | ||
| leading: leadingPaddingInfoViewPiP, | ||
| trailing: 6, | ||
| top: 2, | ||
| bottom: bottomPaddingInfoViewPiP | ||
| ) | ||
|
|
||
| /// Padding configuration for the connection indicator view. | ||
| /// | ||
| /// The trailing and bottom paddings vary depending on the iOS version. | ||
| @MainActor public static let connectionIndicator = PaddingsConfig( | ||
| leading: 0, | ||
| trailing: trailingPaddingConnectionIndicator, | ||
| top: 0, | ||
| bottom: bottomPaddingConnectionIndicator | ||
| ) | ||
|
|
||
| /// Leading padding for the participant info view in PiP mode, | ||
| /// adjusted for iOS 26 and above. | ||
| private static var leadingPaddingInfoViewPiP: CGFloat { | ||
| if #available(iOS 26.0, *) { | ||
| return 16 | ||
| } else { | ||
| return 6 | ||
| } | ||
| } | ||
|
|
||
| /// Bottom padding for the participant info view in PiP mode, | ||
| /// adjusted for iOS 26 and above. | ||
| private static var bottomPaddingInfoViewPiP: CGFloat { | ||
| if #available(iOS 26.0, *) { | ||
| return 4 | ||
| } else { | ||
| return 2 | ||
| } | ||
| } | ||
|
|
||
| /// Trailing padding for the connection indicator, | ||
| /// adjusted for iOS 26 and above. | ||
| private static var trailingPaddingConnectionIndicator: CGFloat { | ||
| if #available(iOS 26.0, *) { | ||
| return 8 | ||
| } else { | ||
| return 0 | ||
| } | ||
| } | ||
|
|
||
| /// Bottom padding for the connection indicator, | ||
| /// adjusted for iOS 26 and above. | ||
| private static var bottomPaddingConnectionIndicator: CGFloat { | ||
| if #available(iOS 26.0, *) { | ||
| return 2 | ||
| } else { | ||
| return 0 | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.