[Enhancement|HiFi]Implement RTCAudioStore as Store #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipavlidakis
changed the base branch from
develop
to
enhancement/hifi/implement-store-coordinator
Generated by 🚫 Danger |
ipavlidakis
force-pushed
the
enhancement/hifi/implement-store-coordinator
branch
from
85513ae to
e2789fd
Compare
ipavlidakis
force-pushed
the
enhancement/hifi/implement-rtcaudio-store-as-store
branch
from
6d4ad42 to
7ae8feb
Compare
ipavlidakis
changed the title
ipavlidakis
force-pushed
the
enhancement/hifi/implement-store-coordinator
branch
from
e2789fd to
855a425
Compare
ipavlidakis
force-pushed
the
enhancement/hifi/implement-rtcaudio-store-as-store
branch
3 times, most recently
from
d27ed23 to
d80c8a6
Compare
ipavlidakis
force-pushed
the
enhancement/hifi/implement-store-coordinator
branch
from
855a425 to
1f26c8c
Compare
ipavlidakis
force-pushed
the
enhancement/hifi/implement-rtcaudio-store-as-store
branch
from
9f33fc8 to
31d363b
Compare
Base automatically changed from
enhancement/hifi/implement-store-coordinator
to
enhancement/hifi/feature-implementation
October 20, 2025 08:44
ipavlidakis
force-pushed
the
enhancement/hifi/implement-rtcaudio-store-as-store
branch
from
31d363b to
c5130b0
Compare
ipavlidakis
force-pushed
the
enhancement/hifi/feature-implementation
branch
from
eb2eb3b to
283a24a
Compare
ipavlidakis
force-pushed
the
enhancement/hifi/implement-rtcaudio-store-as-store
branch
from
c5130b0 to
b5b810e
Compare
Sources/StreamVideo/Utils/AudioSession/AudioDeviceModule/AudioDeviceModule.swift
Outdated
Show resolved
Hide resolved
Sources/StreamVideo/Utils/AudioSession/AudioDeviceModule/AudioDeviceModule.swift
Outdated
Show resolved
Hide resolved
Sources/StreamVideo/Utils/AudioSession/AudioDeviceModule/AudioDeviceModule.swift
Show resolved
Hide resolved
Sources/StreamVideo/Utils/AudioSession/AudioDeviceModule/AudioDeviceModule.swift
Outdated
Show resolved
Hide resolved
Sources/StreamVideo/Utils/AudioSession/AudioDeviceModule/AudioEngineLevelNodeAdapter.swift
Outdated
Show resolved
Hide resolved
Sources/StreamVideo/Utils/AudioSession/AudioDeviceModule/AudioEngineLevelNodeAdapter.swift
Show resolved
Hide resolved
| } else if let audioRecorder = try? AVAudioRecorder.build() { | ||
| mode = .audioRecorder(audioRecorder) | ||
| } else { | ||
| mode = .invalid |
There was a problem hiding this comment.
how can we end up here?
There was a problem hiding this comment.
If the audioRecorder fail to get created
There was a problem hiding this comment.
yes, that's clear, I meant how can that happen?
There was a problem hiding this comment.
The AVAudioRecorder initializer is failable, so if for some reason that fails, we can end up there. It seems that the main reasons for it to fail is to pass an invalid configuration (we are using the same configuration since forever)
|
|
||
| /// Abstraction over the WebRTC audio session that lets the store coordinate | ||
| /// audio behaviour without tying tests to the concrete implementation. | ||
| protocol AudioSessionProtocol: AnyObject { |
There was a problem hiding this comment.
Maybe we're abstracting too much of WebRTC? Might be harder to keep up with newer versions.
There was a problem hiding this comment.
WebRTC attempts to make as minimum changes to platform specific as possible (especially on Audio for iOS). This abstraction is mostly abstracting things common to AVAudioSession and RTCAudioSession. It won't pose a problem when updating for sure.
|
| if let mixer = inputTap, mixer.engine != nil { | ||
| mixer.removeTap(onBus: 0) | ||
| } | ||
| subject?.send(-160) |
There was a problem hiding this comment.
We should use the new constant here
...a/xcbaselines/84F737F3287C13AD00A363F4.xcbaseline/405B1570-F1EC-4638-9C96-FA56CB97DF5B.plist
Outdated
Show resolved
Hide resolved
martinmitrevski
approved these changes
Oct 31, 2025
ipavlidakis
force-pushed
the
enhancement/hifi/implement-rtcaudio-store-as-store
branch
from
5fc3b4c to
a4cd163
Compare
SDK Size
|
Public Interface🚀 No changes affecting the public interface. |
StreamVideo XCSize
Show 88 more objects
|
StreamVideoSwiftUI XCSize
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #976
☑️ Contributor Checklist