Skip to content

Revert change to kick out the user when SFU WS disconnected #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sierpinskid merged 1 commit into from
Nov 21, 2025
Merged

Revert change to kick out the user when SFU WS disconnected #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions Packages/StreamVideo/Runtime/Core/LowLevelClient/RtcSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,20 +253,6 @@ public void Dispose()
//StreamTodo: to make updates more explicit we could make an UpdateService, that we could tell such dependency by constructor and component would self-register for updates
public void Update()
{
if (_terminateCall)
{
_terminateCall = false;

if (ActiveCall != null)
{
#if STREAM_DEBUG_ENABLED
_logs.Error("Sfu Websocket Disconnected IN UPDATE-> Stopping the call. Thread ID: " +
System.Threading.Thread.CurrentThread.ManagedThreadId);
#endif
ActiveCall.LeaveAsync().LogIfFailed();
}
}

_sfuWebSocket.Update();
Publisher?.Update();
_statsSender.Update();
Expand Down Expand Up @@ -535,8 +521,6 @@ private readonly Dictionary<string, VideoResolution> _videoResolutionByParticipa

private MicrophoneDeviceInfo _activeAudioRecordingDevice;

private bool _terminateCall;

private void ClearSession()
{
UnsubscribeFromSfuEvents();
Expand Down Expand Up @@ -1641,12 +1625,6 @@ private void OnPublisherVideoTrackChanged(VideoStreamTrack videoTrack)
private void OnSfuWebSocketDisconnected()
{
//StreamTODO: check how other SDKs are handling this. Ideally we should have call recovery logic here
_terminateCall = true;

#if STREAM_DEBUG_ENABLED
_logs.Error("Sfu Websocket Disconnected -> Schedule stopping the cal. Thread ID: " +
System.Threading.Thread.CurrentThread.ManagedThreadId);
#endif
}

private static bool AssertCallIdMatch(IStreamCall activeCall, string callId, ILogs logs)
Expand Down
Loading