Skip to content

fix device orientation check for screen capturing #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brazol merged 1 commit into from
Apr 8, 2025
Merged

fix device orientation check for screen capturing #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions android/src/main/java/io/getstream/webrtc/flutter/GetUserMediaImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@ private void getDisplayMedia(final Result result, final MediaStream mediaStream,
VideoCapturer videoCapturer = null;
videoCapturer =
new OrientationAwareScreenCapturer(
applicationContext,
mediaProjectionData,
new MediaProjection.Callback() {
@Override
Expand Down
13 changes: 9 additions & 4 deletions android/src/main/java/io/getstream/webrtc/flutter/OrientationAwareScreenCapturer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@
import android.os.Looper;
import android.os.Handler;
import android.os.Build;
import android.os.Bundle;
import android.view.Display;
import android.util.Log;
import android.content.Context;
import android.content.res.Configuration;

/**
* An copy of ScreenCapturerAndroid to capture the screen content while being aware of device orientation
Expand All @@ -46,6 +50,7 @@ public class OrientationAwareScreenCapturer implements VideoCapturer, VideoSink
private MediaProjectionManager mediaProjectionManager;
private WindowManager windowManager;
private boolean isPortrait;
private Context context;

/**
* Constructs a new Screen Capturer.
Expand All @@ -56,10 +61,12 @@ public class OrientationAwareScreenCapturer implements VideoCapturer, VideoSink
* @param mediaProjectionCallback MediaProjection callback to implement application specific
* logic in events such as when the user revokes a previously granted capture permission.
**/
public OrientationAwareScreenCapturer(Intent mediaProjectionPermissionResultData,
public OrientationAwareScreenCapturer(Context context,
Intent mediaProjectionPermissionResultData,
MediaProjection.Callback mediaProjectionCallback) {
this.mediaProjectionPermissionResultData = mediaProjectionPermissionResultData;
this.mediaProjectionCallback = mediaProjectionCallback;
this.context = context;
}

public void onFrame(VideoFrame frame) {
Expand All @@ -76,9 +83,7 @@ public void onFrame(VideoFrame frame) {
}

private boolean isDeviceOrientationPortrait() {
final int surfaceRotation = windowManager.getDefaultDisplay().getRotation();

return surfaceRotation != Surface.ROTATION_90 && surfaceRotation != Surface.ROTATION_270;
return context.getResources().getConfiguration().orientation == Configuration.ORIENTATION_PORTRAIT;
}


Expand Down