Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for capturing and mixing screen audio with microphone audio during Android screen sharing. The implementation uses Android Q's (API 29+) AudioPlaybackCaptureConfiguration to capture system audio and mixes it with the microphone stream in real-time.
Key changes:
- Introduces screen audio capture via
ScreenAudioCapturerusing MediaProjection - Implements PCM audio mixing with clipping in
AudioBufferMixer - Integrates audio mixing into the WebRTC audio pipeline through the audio buffer callback
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| ScreenAudioCapturer.java | New class to capture screen audio using AudioPlaybackCaptureConfiguration (Android Q+) |
| AudioBufferMixer.java | New utility class to mix two PCM 16-bit audio buffers with clipping |
| OrientationAwareScreenCapturer.java | Adds MediaProjection listener interface and improves lifecycle management with isStopping flag and defensive error handling |
| MethodCallHandlerImpl.java | Integrates screen audio mixing by adding audio buffer callback and microphone mute detection |
| GetUserMediaImpl.java | Manages screen audio capture lifecycle, parses includeAudio constraints, and coordinates with MediaProjection events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
android/src/main/java/io/getstream/webrtc/flutter/audio/AudioBufferMixer.java
Show resolved
Hide resolved
android/src/main/java/io/getstream/webrtc/flutter/OrientationAwareScreenCapturer.java
Show resolved
Hide resolved
android/src/main/java/io/getstream/webrtc/flutter/OrientationAwareScreenCapturer.java
Show resolved
Hide resolved
android/src/main/java/io/getstream/webrtc/flutter/audio/AudioBufferMixer.java
Show resolved
Hide resolved
android/src/main/java/io/getstream/webrtc/flutter/audio/ScreenAudioCapturer.java
Show resolved
Hide resolved
android/src/main/java/io/getstream/webrtc/flutter/audio/ScreenAudioCapturer.java
Show resolved
Hide resolved
android/src/main/java/io/getstream/webrtc/flutter/audio/ScreenAudioCapturer.java
Show resolved
Hide resolved
android/src/main/java/io/getstream/webrtc/flutter/audio/ScreenAudioCapturer.java
Show resolved
Hide resolved
renefloor
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for screen sharing audio on Android by mixing the microphone audio with recorded screen audio.