Skip to content

Support async validators #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
killergege wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support async validators #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e50ff96
Handle async validation
killergege May 13, 2022
783f48a
clean diff
killergege May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/MediatR.Extensions.FluentValidation.AspNetCore.Tests/ValidationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ public class CommandValidation : AbstractValidator<Command>
{
public CommandValidation()
{
RuleFor(x => x.Discount).GreaterThanOrEqualTo(0);
RuleFor(x => x.Discount)
.GreaterThanOrEqualTo(0)
.MustAsync(async (_, __) => await Task.Delay(0).ContinueWith(x => true));
}
}

Expand All @@ -65,4 +67,4 @@ public async Task<Unit> Handle(Command request, CancellationToken cancellationTo
return await Unit.Task;
}
}
}
}
9 changes: 5 additions & 4 deletions src/MediatR.Extensions.FluentValidation.AspNetCore/ValidationBehavior.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@ public ValidationBehavior(IEnumerable<IValidator<TRequest>> validators)
_validators = validators;
}

public Task<TResponse> Handle(TRequest request
public async Task<TResponse> Handle(TRequest request
, CancellationToken cancellationToken
, RequestHandlerDelegate<TResponse> next
)
{
var failures = _validators
.Select(v => v.Validate(request))
var failures =
(await Task.WhenAll(_validators.Select(async v => await v.ValidateAsync(request, cancellationToken))))
.Where(result => result != null)
.SelectMany(result => result.Errors)
.Where(f => f != null)
.ToList();
Expand All @@ -32,7 +33,7 @@ public Task<TResponse> Handle(TRequest request
throw new ValidationException(failures);
}

return next();
return await next();
}
}
}