Data components map improvements#894
Merged
onebeastchris merged 2 commits intoGeyserMC:feature/1.21.5from May 5, 2025
Merged
Conversation
- Added #contains and #remove methods - Make #put allow null values - Add Javadoc to make usage of null values clear
onebeastchris
approved these changes
May 5, 2025
Member
onebeastchris
left a comment
onebeastchris
left a comment
There was a problem hiding this comment.
LGTM - this could probably be improved further in the future, but it's definitely a neat improvement for the time being
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of small improvements to the
DataComponentsclass:contains(DataComponentType<?>)andremove(DataComponentType<T>)methods.put(DataComponentType<T>, T)allow null values.In the future, an additional, separate class should probably be created for data component patches.
This PR also makes a small change to
DataComponentTypes: afromKey(Key)method was added.