This repository was archived by the owner on Nov 7, 2023. It is now read-only.
Open
Conversation
Author
|
As noted in a discussion this morning with the team. What does everyone think about just fixing the |
moxley
approved these changes
Mar 21, 2019
I'm ok either way, but I prefer to merge this PR so we can move on to other things. |
tehprofessor
approved these changes
Mar 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Phoenix from the imported deps in the formatter config and formats the project. Plug should remain only because we are implementing plugs so importing the formatter config makes sense. Although, truth be told I haven't checked the Plug format config so there might not be anything there to be concerned with :)