Conversation
Reviewer's GuideAdds a new Actual Budget 2 application definition with associated Docker Compose fragments and user documentation, mirroring the existing app patterns to test docs build and app wiring. Flow diagram for composing ActualBudget2 Docker fragmentsgraph TD
A[Start_DockSTARTer_configuration] --> B[Select_enable_ActualBudget2_app]
B --> C[Load_base_actualbudget2_compose_fragment]
C --> D[Merge_actualbudget2_ports_fragment]
D --> E[Merge_actualbudget2_storage_fragments_storage_storage2_storage3_storage4]
E --> F[Merge_actualbudget2_arch_specific_fragment_x86_64_or_aarch64]
F --> G[Merge_hostname_and_network_mode_fragments]
G --> H[Resolve_environment_variables_from_env_files]
H --> I[Generate_final_docker_compose_for_actualbudget__instance]
I --> J[Deploy_or_update_container_with_Docker]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 4 issues, and left some high level feedback:
- The new app is named
actualbudget2in the docs and directory structure, but all service names, env vars, and labels still useactualbudget<__instance>naming; consider aligning the app name consistently so it’s clear whether this is a separate variant or just a duplicate of the existing Actual Budget app. - The docs badge link for
Compose Templatesstill points to.apps/actualbudgetrather than.apps/actualbudget2; update this if the intent is to reference the newly added app definition.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new app is named `actualbudget2` in the docs and directory structure, but all service names, env vars, and labels still use `actualbudget<__instance>` naming; consider aligning the app name consistently so it’s clear whether this is a separate variant or just a duplicate of the existing Actual Budget app.
- The docs badge link for `Compose Templates` still points to `.apps/actualbudget` rather than `.apps/actualbudget2`; update this if the intent is to reference the newly added app definition.
## Individual Comments
### Comment 1
<location> `.apps/actualbudget2/actualbudget.yml:2-10` </location>
<code_context>
+services:
+ actualbudget<__instance>:
+ image: actualbudget/actual-server:${ACTUALBUDGET<__INSTANCE>__TAG?}
</code_context>
<issue_to_address>
**issue (bug_risk):** Service name and env-prefix appear to collide with the existing `actualbudget` app rather than being unique to `actualbudget2`.
Because this lives under `.apps/actualbudget2/`, using `actualbudget<__instance>` and `ACTUALBUDGET<__INSTANCE>__...` will likely clash with the existing `actualbudget` app if both are enabled. Please consider renaming these to `actualbudget2<__instance>` with a corresponding `ACTUALBUDGET2<__INSTANCE>__...` prefix to keep the two apps isolated.
</issue_to_address>
### Comment 2
<location> `.apps/actualbudget2/actualbudget.labels.yml:6` </location>
<code_context>
+ labels:
+ com.dockstarter.appinfo.deprecated: "false"
+ com.dockstarter.appinfo.description: "Super fast, privacy-focused app for managing your finances."
+ com.dockstarter.appinfo.nicename: "ActualBudget<__Instance>"
</code_context>
<issue_to_address>
**issue (bug_risk):** The nicename placeholder casing (`<__Instance>`) may not match the templating convention used elsewhere.
Elsewhere in this config the placeholder is consistently `<__instance>`, but here it’s `<__Instance>`. If the templating engine is case-sensitive, this value may not be replaced and could render literally as `ActualBudget<__Instance>`. Please align the casing with the other placeholders (e.g. `ActualBudget<__instance>`) unless this variant is intentionally supported.
</issue_to_address>
### Comment 3
<location> `docs/apps/actualbudget2.md:9` </location>
<code_context>
+
+## Description
+
+[Actual Budget](https://actualbudget.org) is a fast, privacy-focused, and open-source personal finance app built with a local-first approach. It’s written in NodeJS and is 100% free to use. With Actual, you own your data-manage your finances confidently knowing you can do whatever you want with your information, including syncing changes seamlessly across all your devices, with optional end-to-end encryption for maximum privacy.
+
+## Install/Setup
</code_context>
<issue_to_address>
**issue (typo):** Clarify the phrase "data-manage" to avoid it reading like a typo.
This reads as if "data-manage" is a single, unusual word. Consider adding a conjunction (e.g., "you own your data and manage your finances confidently") or an em dash ("you own your data—manage your finances confidently") to make the meaning clear.
```suggestion
[Actual Budget](https://actualbudget.org) is a fast, privacy-focused, and open-source personal finance app built with a local-first approach. It’s written in NodeJS and is 100% free to use. With Actual, you own your data and manage your finances confidently knowing you can do whatever you want with your information, including syncing changes seamlessly across all your devices, with optional end-to-end encryption for maximum privacy.
```
</issue_to_address>
### Comment 4
<location> `docs/apps/actualbudget2.md:14` </location>
<code_context>
+## Install/Setup
+
+This application does not have any specific setup instructions documented. If
+you need assistance setting up this application please visit our
+[support page](https://dockstarter.com/basics/support).
</code_context>
<issue_to_address>
**issue (typo):** Add a comma before "please" for correct sentence structure.
In the sentence `you need assistance setting up this application please visit our`, add a comma before "please" (`…application, please visit our`) to improve readability and match standard grammar.
```suggestion
you need assistance setting up this application, please visit our
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+2
to
+10
| actualbudget<__instance>: | ||
| container_name: ${ACTUALBUDGET<__INSTANCE>__CONTAINER_NAME?} | ||
| env_file: .env.app.actualbudget<__instance> | ||
| environment: | ||
| - TZ=${TZ?} | ||
| restart: ${ACTUALBUDGET<__INSTANCE>__RESTART?} | ||
| volumes: | ||
| - /etc/localtime:/etc/localtime:ro | ||
| - ${DOCKER_VOLUME_CONFIG?}/actualbudget<__instance>:/data |
There was a problem hiding this comment.
issue (bug_risk): Service name and env-prefix appear to collide with the existing actualbudget app rather than being unique to actualbudget2.
Because this lives under .apps/actualbudget2/, using actualbudget<__instance> and ACTUALBUDGET<__INSTANCE>__... will likely clash with the existing actualbudget app if both are enabled. Please consider renaming these to actualbudget2<__instance> with a corresponding ACTUALBUDGET2<__INSTANCE>__... prefix to keep the two apps isolated.
|
|
||
| ## Description | ||
|
|
||
| [Actual Budget](https://actualbudget.org) is a fast, privacy-focused, and open-source personal finance app built with a local-first approach. It’s written in NodeJS and is 100% free to use. With Actual, you own your data-manage your finances confidently knowing you can do whatever you want with your information, including syncing changes seamlessly across all your devices, with optional end-to-end encryption for maximum privacy. |
There was a problem hiding this comment.
issue (typo): Clarify the phrase "data-manage" to avoid it reading like a typo.
This reads as if "data-manage" is a single, unusual word. Consider adding a conjunction (e.g., "you own your data and manage your finances confidently") or an em dash ("you own your data—manage your finances confidently") to make the meaning clear.
Suggested change
| [Actual Budget](https://actualbudget.org) is a fast, privacy-focused, and open-source personal finance app built with a local-first approach. It’s written in NodeJS and is 100% free to use. With Actual, you own your data-manage your finances confidently knowing you can do whatever you want with your information, including syncing changes seamlessly across all your devices, with optional end-to-end encryption for maximum privacy. | |
| [Actual Budget](https://actualbudget.org) is a fast, privacy-focused, and open-source personal finance app built with a local-first approach. It’s written in NodeJS and is 100% free to use. With Actual, you own your data and manage your finances confidently knowing you can do whatever you want with your information, including syncing changes seamlessly across all your devices, with optional end-to-end encryption for maximum privacy. |
| ## Install/Setup | ||
|
|
||
| This application does not have any specific setup instructions documented. If | ||
| you need assistance setting up this application please visit our |
There was a problem hiding this comment.
issue (typo): Add a comma before "please" for correct sentence structure.
In the sentence you need assistance setting up this application please visit our, add a comma before "please" (…application, please visit our) to improve readability and match standard grammar.
Suggested change
| you need assistance setting up this application please visit our | |
| you need assistance setting up this application, please visit our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Purpose
Describe the problem or feature in addition to a link to the issues.
Approach
How does this change address the problem?
Open Questions and Pre-Merge TODOs
Check all boxes as they are completed
Learning
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Requirements
Check all boxes as they are completed
Summary by Sourcery
Add a new Actual Budget 2 application definition and documentation to DockSTARTer.
New Features:
Documentation: