Fix the --theme-*` command line options

[CLHatch]

Pull request

Purpose
Describe the problem or feature in addition to a link to the issues.

Approach
How does this change address the problem?

Open Questions and Pre-Merge TODOs
Check all boxes as they are completed

• Use github checklists. When solved, check the box and explain the answer.

Learning
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem

Requirements
Check all boxes as they are completed

• These changes meet the standards for contributing.
• I have read the code of conduct.

Summary by Sourcery

Fix handling of theme-related command-line options when updating configuration values.

Bug Fixes:

• Correct validation of configuration variables and values for theme command-line options so both must be defined before applying changes.

Enhancements:

• Simplify theme configuration updates by relying on the default target configuration file in the config_set helper.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes the handling of the --theme-* command-line options by correctly validating that both the configuration variable and value are set, and by updating the config_set invocation to rely on its default target instead of passing an explicit menu INI file path.

Sequence diagram for handling --theme-* command line options

sequenceDiagram
    actor User
    participant Shell
    participant run_command
    participant config_set

    User->>Shell: dockstarter --theme-borders
    Shell->>run_command: parse_arguments

    run_command->>run_command: set ConfigVar and ConfigValue
    run_command->>run_command: validate [[ -z ConfigVar || -z ConfigValue ]]
    alt ConfigVar or ConfigValue missing
        run_command->>run_command: fatal configuration error
        run_command-->>Shell: nonzero exit
        Shell-->>User: error message
    else Both ConfigVar and ConfigValue set
        run_command->>config_set: config_set ConfigVar ConfigValue
        config_set-->>run_command: status code
        alt use_dialog_box is true
            run_command->>run_command: menu_dialog_example Title CURRENT_COMMANDLINE
        end
        run_command-->>Shell: return status
        Shell-->>User: command completes
    end

Loading

File-Level Changes

Change	Details	Files
Correct validation of theme-related configuration arguments before applying them.	Tighten the conditional to require both ConfigVar and ConfigValue to be non-empty before proceeding. Ensure that a missing configuration variable or value correctly triggers a fatal error for theme-related commands.	.includes/cmdline.sh
Align config_set invocation for theme options with the expected function signature and defaults.	Remove the explicit MENU_INI_FILE argument from the config_set call for theme options so it uses the default configuration target. Preserve subsequent behavior, including dialog-based notifications, while correcting the argument list.	.includes/cmdline.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}