Open
Conversation
Ronnie-Skylar
commented
Apr 16, 2019
Ronnie-Skylar
commented
- Added -
- Functions for pushing and checking notification in .inc and .php.
- Haul/SAMPSON dependency.
- Changed -
- Changed tfasamp.pwn -> tfasamp.inc. Because without changing the file format it would not #include <>
- Removed raw return type and left only json return type.
- Made the .php data return consistent.
- HHTP response was handled with respect to an integer. Where as the data returned was always string. Changed it to incorporate that.
As most of the data retrieved is decoded with respect to json, as because it makes the whole process a lot more easier. Thus the "raw" return type has been removed. Instead "json" is compulsory. Added 2 new switch cases for the command for $_GET which is checkNoti(fication) and pushNoti(fication)
There were parts where the variable was assigned simple values, but as the returned data is decoded in json, it has been changed to accommodate the value in json format. Some array's identifier was not consistent, which is not anymore. Added functions for pushNotification & checkNotification which pushes a notification in the client's device and the latter checks if the authorization was approved or denied.
Added further functionality to send notification to client's device and to check if it was approved or not. HTTP response's data was handled on basis of an integer. Whereas what was returning was not integer at all. But json data. Thus it is now decoded and then values are assigned accordingly. Added the JSON dependency to accommodate the JSON parse function. Changed the format from .pwn -> .inc, as simply calling #include <tfasamp> wouldn't find the file.
GiamPy5
reviewed
Apr 16, 2019
Owner
|
Looks good. Just remove the link from the README.md and I'll merge it! |
GiamPy5
reviewed
Apr 19, 2019
GiamPy5
reviewed
Apr 19, 2019
GiamPy5
reviewed
Apr 19, 2019
GiamPy5
reviewed
Apr 19, 2019
Author
|
The function names have been changed. Prefix added properly. And are now consistent with the others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.