feat(remove): Remove prepacked bins for linux#176
Closed
dark0dave wants to merge 1 commit intoGibberlings3:masterfrom
Closed
feat(remove): Remove prepacked bins for linux#176dark0dave wants to merge 1 commit intoGibberlings3:masterfrom
dark0dave wants to merge 1 commit intoGibberlings3:masterfrom
Conversation
9d2686e to
0c565f3
Compare
0c565f3 to
978e557
Compare
978e557 to
0cca95f
Compare
0cca95f to
76f23d2
Compare
76f23d2 to
aa4af73
Compare
aa4af73 to
6ebd854
Compare
6ebd854 to
7bc274e
Compare
7bc274e to
d4daca8
Compare
d4daca8 to
2e936f9
Compare
Signed-off-by: dark0dave <dark0dave@mykolab.com>
2e936f9 to
3fc2ca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appologies, I've been frustrated by this binary inclusion before. I have fixed this with a:
This should locate or complain if a binary is missing on the path of the intended user.
The reason this is done, is that end users maybe using different version of weidu/lua to that which is being bundled.
Ideally we let linux users handle the missing binary.