fix(bins): BINS BEGONE

[dark0dave]

Signed-off-by: dark0dave dark0dave@mykolab.com

[dark0dave]

I've put back the rm -rf commands tho, I think its helpful to leave them in order for debug.

yeah bin checking should happen up front at the start, so I don't scream in frustration after 5 minutes

[dark0dave]

Also please understand that packing your own binaries for linux or macos is inherently bad and straight up dangerous.

[GraionDilach]

MacOS is inherently bad to begin with so I don't really see a difference on that front.

[GraionDilach]

Please keep in mind that @K4thos merges PRs sporadically, so don't take it personal if you're perceived as ignored.

[dark0dave]

Thats fine, I just wanted to fix this.

[Argent77]

@dark0dave Is there a reason why this PR removes shortcut creation support for Linux?

[Argent77]

EET_end seems to complete with warnings with this PR. I couldn't find anything helpful in the log, except for a short message about chmod failing to set the executable bit on a weidu binary. Possibly a regression from the binary removal?

Suggestion: The readme should be updated with the information that on Linux and macOS platforms the weidu and lua binaries must be present on the system. I don't know if a specific Lua version is required. The binary originally shipped with EET was Lua 5.3, but some distros may still provide older versions by default.

[dark0dave]

Sorry yes re shortcuts my bad. Will fix.

[dark0dave]

I'll fix the chmod error. Likely trying to chmod exiting binaries.

[dark0dave]

And I'll update the readme.

[dark0dave]

@Argent77 and @GraionDilach those fixes have been applied please take another look

[Argent77]

I'd suggest to add these instructions to the readme-EET.html as well.

[dark0dave]

@Argent77 done html added.

[mleduque]

I'm not there for review, I couldn't say anything about the content :p

I tried to install EET with this patch applied on a non-case-insensitive FS.

At this specific point, I get

lua EET/lib/tlk_cnt.lua
lua: cannot open eet/lib/tlk_cnt.lua: No such file or directory

Shell command failed to execute: lua EET/lib/tlk_cnt.lua

I find it a bit surprising, it (correctly) identifies the path as EET/lib/tlk_cnt.lua in the PRINT but then goes on to replace EET with eet in the AT_NOW.

[mleduque]

And it's ever weirder that the previous AT_NOW (weidu invocation) does not end up with the same error. I must have done something wrong...