Separate out the PCU iteration of patch_dir's direct contents to omit a stray backslash.#187
Open
GraionDilach wants to merge 1 commit intoGibberlings3:masterfrom
Open
Conversation
… a stray backslash . WeiDU 251's case-sensitive changes break path handling with redundant backslashes in the path (at least on Linux).
Contributor
Author
|
The PR is intentionally drafted until v251 is stabilized. |
|
Just to report, the WeiDU devs have fixed the |
Contributor
Author
|
Ready for review then, considering that covers all issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WeiDU 251's case-sensitive changes break path handling with redundant backslashes in the path (at least on Linux).
Note that isn't enough alone to fix all v251 issues, because lacking WeiDUorg/weidu#331 requires changes inlib/tlk_cnt.luato convert the lower-case WeiDU lang folder variable to EE mixed-case folder name, but I don't think that's an EET issue and I just hope WeiDU updates to store the folder in mixed case in their own configuration before the changes sprinkle into a stable build.EDIT: That is fixed.
Reported by @BettaGeorge on Discord.