Skip to content

Commit fa0745f

Browse files
authored
Merge pull request #265 from joostas/parameterless-scalar-function
Add overload to register parameterless scalar function
2 parents e9a64a0 + b909e0a commit fa0745f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

DuckDB.NET.Data/DuckDBConnection.ScalarFunction.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ partial class DuckDBConnection
1515
{
1616
#if NET8_0_OR_GREATER
1717
[Experimental("DuckDBNET001")]
18-
public void RegisterScalarFunction<TResult>(string name, Action<IReadOnlyList<IDuckDBDataReader>, IDuckDBDataWriter, ulong> action, bool isPureFunction = false)
18+
public void RegisterScalarFunction<TResult>(string name, Action<IDuckDBDataWriter, ulong> action, bool isPureFunction = false)
1919
{
20-
RegisterScalarMethod(name, action, TypeExtensions.GetLogicalType<TResult>(), varargs: false, !isPureFunction);
20+
RegisterScalarMethod(name, (_, w, index) => action(w, index), TypeExtensions.GetLogicalType<TResult>(), varargs: false, !isPureFunction);
2121
}
2222

2323
[Experimental("DuckDBNET001")]

DuckDB.NET.Test/ScalarFunctionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public void RegisterScalarFunctionWithVarargs()
6464
public void RegisterScalarFunctionWithoutParameters()
6565
{
6666
var values = new List<long>();
67-
Connection.RegisterScalarFunction<long>("my_random", (_, writer, rowCount) =>
67+
Connection.RegisterScalarFunction<long>("my_random", (writer, rowCount) =>
6868
{
6969
for (ulong index = 0; index < rowCount; index++)
7070
{

0 commit comments

Comments
 (0)