Added ability for intercept in geom.hair to take vector to function as lolipop#1519
Open
hewsond wants to merge 1 commit intoGiovineItalia:masterfrom
Open
Added ability for intercept in geom.hair to take vector to function as lolipop#1519hewsond wants to merge 1 commit intoGiovineItalia:masterfrom
hewsond wants to merge 1 commit intoGiovineItalia:masterfrom
Conversation
…s lolipop Documented hair as lolipop in geometries documentation Added Geom.hair update as lolipop to news Added tests for Geom.hair lolipop
Member
|
Another possibility here is changing the syntax to |
Author
|
I'm not an expert on the whole grammar of graphics thing but IMO the intercept argument as you suggest does sound much nicer and cleaner. I'm happy to have at re-basing to work in that way once you've done the refactor if required. |
Member
|
@Mattriks did you finished the aforementioned PR? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chainged Geom.hair
Documented hair as lolipop in geometries documentation
Added Geom.hair update as lolipop to news
Added tests for Geom.hair lolipop
Fixes #XXX
Contributor checklist:
NEWS.mdsquash'ed orfixup'ed junk commits with git-rebaseProposed changes
Use length check on
interceptinGeom.hairto determine if it is same length as number of points want to draw hairs for.If it is same length, don't fill end point vector, just use the supplied vector.
Doc building issues
I've added it to the test files and above you can see the output, however when i try to build the documentation I get an error:
MethodError: no method matching isless(::Array{Float64,1}, ::Int64)Though it isn't the only
@exampleblock that gives some errors.