Voidify zend_cfg_compute_dominators_tree()

It always returned SUCCESS

Author: Girgias

Zend/Optimizer/dfa_pass.c

@@ -64,9 +64,7 @@ zend_result zend_dfa_analyze_op_array(zend_op_array *op_array, zend_optimizer_ct
 	}
 
 	/* Compute Dominators Tree */
-	if (zend_cfg_compute_dominators_tree(op_array, &ssa->cfg) != SUCCESS) {
-		return FAILURE;
-	}
+	zend_cfg_compute_dominators_tree(op_array, &ssa->cfg);
 
 	/* Identify reducible and irreducible loops */
 	if (zend_cfg_identify_loops(op_array, &ssa->cfg) != SUCCESS) {

Zend/Optimizer/zend_cfg.c

@@ -681,7 +681,7 @@ static void compute_postnum_recursive(
 
 /* Computes dominator tree using algorithm from "A Simple, Fast Dominance Algorithm" by
  * Cooper, Harvey and Kennedy. */
-ZEND_API int zend_cfg_compute_dominators_tree(const zend_op_array *op_array, zend_cfg *cfg) /* {{{ */
+ZEND_API void zend_cfg_compute_dominators_tree(const zend_op_array *op_array, zend_cfg *cfg) /* {{{ */
 {
 	zend_basic_block *blocks = cfg->blocks;
 	int blocks_count = cfg->blocks_count;
@@ -768,7 +768,6 @@ ZEND_API int zend_cfg_compute_dominators_tree(const zend_op_array *op_array, zen
 	}
 
 	free_alloca(postnum, use_heap);
-	return SUCCESS;
 }
 /* }}} */
 

Zend/Optimizer/zend_cfg.h

@@ -119,7 +119,7 @@ BEGIN_EXTERN_C()
 ZEND_API void zend_build_cfg(zend_arena **arena, const zend_op_array *op_array, uint32_t build_flags, zend_cfg *cfg);
 void zend_cfg_remark_reachable_blocks(const zend_op_array *op_array, zend_cfg *cfg);
 ZEND_API void zend_cfg_build_predecessors(zend_arena **arena, zend_cfg *cfg);
-ZEND_API int zend_cfg_compute_dominators_tree(const zend_op_array *op_array, zend_cfg *cfg);
+ZEND_API void zend_cfg_compute_dominators_tree(const zend_op_array *op_array, zend_cfg *cfg);
 ZEND_API int zend_cfg_identify_loops(const zend_op_array *op_array, zend_cfg *cfg);
 
 END_EXTERN_C()

ext/opcache/jit/zend_jit.c

@@ -1280,9 +1280,7 @@ static int zend_jit_build_cfg(const zend_op_array *op_array, zend_cfg *cfg)
 	zend_cfg_build_predecessors(&CG(arena), cfg);
 
 	/* Compute Dominators Tree */
-	if (zend_cfg_compute_dominators_tree(op_array, cfg) != SUCCESS) {
-		return FAILURE;
-	}
+	zend_cfg_compute_dominators_tree(op_array, cfg);
 
 	/* Identify reducible and irreducible loops */
 	if (zend_cfg_identify_loops(op_array, cfg) != SUCCESS) {