ext/random: Remove useless variable

Girgias · Girgias · commit 5d177c17ed20 · 2025-11-16T22:34:10.000Z
diff --git a/ext/random/random.c b/ext/random/random.c
@@ -524,9 +524,8 @@ PHP_FUNCTION(mt_srand)
 PHP_FUNCTION(mt_rand)
 {
 	zend_long min, max;
-	int argc = ZEND_NUM_ARGS();
 
-	if (argc == 0) {
+	if (ZEND_NUM_ARGS() == 0) {
 		/* genrand_int31 in mt19937ar.c performs a right shift */
 		RETURN_LONG(php_mt_rand() >> 1);
 	}
@@ -562,9 +561,8 @@ PHP_FUNCTION(mt_getrandmax)
 PHP_FUNCTION(rand)
 {
 	zend_long min, max;
-	int argc = ZEND_NUM_ARGS();
 
-	if (argc == 0) {
+	if (ZEND_NUM_ARGS() == 0) {
 		/* genrand_int31 in mt19937ar.c performs a right shift */
 		RETURN_LONG(php_mt_rand() >> 1);
 	}

Original file line number	Diff line number	Diff line change
`@@ -524,9 +524,8 @@ PHP_FUNCTION(mt_srand)`
`524`	`524`	`PHP_FUNCTION(mt_rand)`
`525`	`525`	`{`
`526`	`526`	`zend_long min, max;`
`527`		`- int argc = ZEND_NUM_ARGS();`
`528`	`527`
`529`		`- if (argc == 0) {`
	`528`	`+ if (ZEND_NUM_ARGS() == 0) {`
`530`	`529`	`/* genrand_int31 in mt19937ar.c performs a right shift */`
`531`	`530`	`RETURN_LONG(php_mt_rand() >> 1);`
`532`	`531`	`}`
`@@ -562,9 +561,8 @@ PHP_FUNCTION(mt_getrandmax)`
`562`	`561`	`PHP_FUNCTION(rand)`
`563`	`562`	`{`
`564`	`563`	`zend_long min, max;`
`565`		`- int argc = ZEND_NUM_ARGS();`
`566`	`564`
`567`		`- if (argc == 0) {`
	`565`	`+ if (ZEND_NUM_ARGS() == 0) {`
`568`	`566`	`/* genrand_int31 in mt19937ar.c performs a right shift */`
`569`	`567`	`RETURN_LONG(php_mt_rand() >> 1);`
`570`	`568`	`}`