navbar issue #13
Open
navbar issue #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulrana95
reviewed
Jul 12, 2018
src/navbar/nav.html
Outdated
| <li>About us</li> | ||
| <li>Profile</li> | ||
| <li class="search"> | ||
| <input type="text" class="search-input"maxlength="40" placeholder="Search"> |
There was a problem hiding this comment.
Use proper indentation
|
You need to create React Components |
rahulrana95
reviewed
Jul 12, 2018
src/navbar/nav.html
Outdated
| <input type="text" class="search-input"maxlength="40" placeholder="Search"> | ||
| <input type="submit" value="Search" class="searchButton"> | ||
| </li> | ||
| <li>Logout</li> |
There was a problem hiding this comment.
why this value is hard coded
Is user always going to logout ?
rahulrana95
reviewed
Jul 12, 2018
|
@megha070 Kindly share your screenshots of the navbar created. |
|
|
|
@megha070 Kindly bring the Home, Who we are etc, in the centre in alignment with the logo image. |
|
After that @megha070 you need to convert these to React Components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.